[PubSub to Datadog] Updating Datadog template to include full pubSub message by default #1579
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dtru-ddog
force-pushed
the
dan.trujillo/update-includepubsubmessage-default
branch
from
0d76602
to
bd1dfe2
Compare
ash-ddog
approved these changes
May 20, 2024
dtru-ddog
force-pushed
the
dan.trujillo/update-includepubsubmessage-default
branch
from
bd1dfe2
to
7d68385
Compare
dtru-ddog
force-pushed
the
dan.trujillo/update-includepubsubmessage-default
branch
from
7d68385
to
a4804c8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
============================================
- Coverage 44.79% 41.26% -3.53%
- Complexity 700 2884 +2184
============================================
Files 297 746 +449
Lines 15894 43633 +27739
Branches 1569 4645 +3076
============================================
+ Hits 7119 18005 +10886
- Misses 8245 24111 +15866
- Partials 530 1517 +987
|
liferoad
reviewed
Jun 4, 2024
| @@ -40,7 +40,7 @@ on [Metadata Annotations](https://github.com/GoogleCloudPlatform/DataflowTemplat | |||
| * **apiKey** : The Datadog API key. You must provide this value if the `apiKeySource` is set to `PLAINTEXT` or `KMS`. For more information, see API and Application Keys (https://docs.datadoghq.com/account_management/api-app-keys/) in the Datadog documentation. | |||
| * **batchCount** : The batch size for sending multiple events to Datadog. The default is `1` (no batching). | |||
| * **parallelism** : The maximum number of parallel requests. The default is `1` (no parallelism). | |||
| * **includePubsubMessage** : Whether to include the full Pub/Sub message in the payload. The default is `false` (only the data element is included in the payload). | |||
| * **includePubsubMessage** : Whether to include the full Pub/Sub message in the payload. The default is `true` (all elements, including data element, are included in the payload). | |||
There was a problem hiding this comment.
We usually do not recommend changing the default value. What if we just update the doc to mention setting this to True is recommended?
camilledolle
reviewed
Jun 4, 2024
| @@ -65,7 +65,7 @@ variable "parallelism" { | |||
|
|
|||
| variable "includePubsubMessage" { | |||
| type = bool | |||
| description = "Include full Pub/Sub message in the payload (true/false). Defaults to false (only data element is included in the payload)." | |||
| description = "Include full Pub/Sub message in the payload (true/false). Defaults to true (all elements, including data element, are included in the payload)." | |||
| default = null | |||
There was a problem hiding this comment.
Should we update the default here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Given customer feedback and to help improve parity with legacy logging structure updating default
includePubsubMessageoption to be true.