Reverse replication reader IT - broken down into single vs multi shard #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyakhajanchi
requested review from
Deep1998 and
asthamohta
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1575 +/- ##
============================================
+ Coverage 40.93% 41.20% +0.26%
- Complexity 2813 3145 +332
============================================
Files 740 746 +6
Lines 42832 43621 +789
Branches 4581 4643 +62
============================================
+ Hits 17533 17972 +439
- Misses 23798 24133 +335
- Partials 1501 1516 +15
|
aksharauke
requested changes
May 23, 2024
.../test/java/com/google/cloud/teleport/v2/templates/SpannerChangeStreamToGcsCustomShardIT.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/google/cloud/teleport/v2/templates/SpannerChangeStreamToGcsMultiShardIT.java
Show resolved
Hide resolved
...loud-platform/src/main/java/org/apache/beam/it/gcp/storage/conditions/GCSArtifactsCheck.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/google/cloud/teleport/v2/templates/SpannerChangeStreamToGcsMultiShardIT.java
Show resolved
Hide resolved
aksharauke
approved these changes
May 28, 2024
...c/test/java/com/google/cloud/teleport/v2/templates/SpannerChangeStreamToGcsMultiShardIT.java
Outdated
Show resolved
Hide resolved
aksharauke
added
the
Google LGTM
copybara-service
bot
merged commit 48697e8
into
GoogleCloudPlatform:main
19 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.