Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BULK] Misc changes across types, logging and options #1574

Merged
merged 4 commits into from
May 20, 2024

Conversation

Deep1998
Copy link
Contributor

@Deep1998 Deep1998 commented May 17, 2024

This PR consists of

  1. Support for INTERVAL type
  2. Adding a Log Level parameter
  3. Removing regex constraint for source database
  4. Deleting the deprecated ResultSetToMutation package

@Deep1998 Deep1998 requested a review from a team as a code owner May 17, 2024 09:03
@Deep1998 Deep1998 requested review from manitgupta and bharadwaj-aditya and removed request for a team May 17, 2024 09:03
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.93%. Comparing base (bcf01b8) to head (51b714d).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1574      +/-   ##
============================================
- Coverage     40.93%   40.93%   -0.01%     
- Complexity     2813     3073     +260     
============================================
  Files           740      739       -1     
  Lines         42832    42855      +23     
  Branches       4581     4582       +1     
============================================
+ Hits          17533    17541       +8     
- Misses        23798    23814      +16     
+ Partials       1501     1500       -1     
Components Coverage Δ
spanner-templates 59.84% <92.30%> (+0.04%) ⬆️
spanner-import-export 65.57% <ø> (-0.03%) ⬇️
spanner-live-forward-migration 73.67% <100.00%> (+0.09%) ⬆️
spanner-live-reverse-replication 48.64% <100.00%> (+0.12%) ⬆️
spanner-bulk-migration 78.01% <92.30%> (+0.32%) ⬆️
Files Coverage Δ
...er/migrations/avro/GenericRecordTypeConvertor.java 95.55% <100.00%> (+0.35%) ⬆️
...cloud/teleport/v2/templates/SourceDbToSpanner.java 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

Copy link
Contributor

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharadwaj-aditya bharadwaj-aditya added the Google LGTM Approval of a pull request to be merged into the repository label May 20, 2024
@bharadwaj-aditya
Copy link
Contributor

CodeCove says - Project coverage is 40.93%

@Deep1998
Copy link
Contributor Author

Codecov

Yes that is for entire teleport repository.

@Deep1998 Deep1998 changed the title [BULK] Misc changes across logging and options [BULK] Misc changes across types, logging and options May 20, 2024
@copybara-service copybara-service bot merged commit 768694d into GoogleCloudPlatform:main May 20, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Google LGTM Approval of a pull request to be merged into the repository size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants