GcsToSourceDB template integration test - Spanner Reverse replication writer end to end IT with reader job #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darshan-sj
requested review from
manitgupta and
asthamohta
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
============================================
- Coverage 40.92% 40.89% -0.04%
- Complexity 2833 3105 +272
============================================
Files 743 744 +1
Lines 43295 43385 +90
Branches 4620 4629 +9
============================================
+ Hits 17720 17742 +22
- Misses 24064 24130 +66
- Partials 1511 1513 +2
|
manitgupta
reviewed
May 16, 2024
...test/java/com/google/cloud/teleport/v2/templates/utils/ReaderDataflowJobResourceManager.java
Outdated
Show resolved
Hide resolved
it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/TemplateTestBase.java
Outdated
Show resolved
Hide resolved
manitgupta
reviewed
May 17, 2024
...rm/src/main/java/org/apache/beam/it/gcp/dataflow/FlexTemplateDataflowJobResourceManager.java
Show resolved
Hide resolved
manitgupta
approved these changes
May 17, 2024
manitgupta
added
the
Google LGTM
darshan-sj
force-pushed
the
rr-with-reader-it
branch
from
3e529b1
to
aa1ae8d
Compare
Polber
reviewed
May 17, 2024
There was a problem hiding this comment.
This file is missing a license which is why copybara step fails
aksharauke
reviewed
May 22, 2024
...sourcedb/src/test/java/com/google/cloud/teleport/v2/templates/GCSToSourceDbWithReaderIT.java
Show resolved
Hide resolved
darshan-sj
force-pushed
the
rr-with-reader-it
branch
from
aa1ae8d
to
f11965f
Compare
copybara-service
bot
merged commit 951944a
into
GoogleCloudPlatform:main
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.