Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Data type size, generated columns, charset and synth_id CUJs #1556

Merged
merged 2 commits into from
May 21, 2024
Merged

Add Data type size, generated columns, charset and synth_id CUJs #1556

merged 2 commits into from
May 21, 2024

Conversation

manitgupta
Copy link
Member

No description provided.

@manitgupta manitgupta requested a review from a team as a code owner May 14, 2024 12:21
@manitgupta manitgupta requested review from asthamohta and VardhanThigle and removed request for a team May 14, 2024 12:21
@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.30%. Comparing base (8dfb6de) to head (d2416bd).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1556      +/-   ##
============================================
+ Coverage     40.92%   43.30%   +2.38%     
+ Complexity     2805      633    -2172     
============================================
  Files           739      290     -449     
  Lines         42855    15435   -27420     
  Branches       4582     1544    -3038     
============================================
- Hits          17537     6684   -10853     
+ Misses        23818     8233   -15585     
+ Partials       1500      518     -982
Components Coverage Δ
spanner-templates 55.31% <ø> (-4.53%) ⬇️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 73.67% <ø> (ø)
spanner-live-reverse-replication 48.52% <ø> (-0.12%) ⬇️
spanner-bulk-migration 78.01% <ø> (ø)

see 466 files with indirect coverage changes

darshan-sj
darshan-sj approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darshan-sj darshan-sj added the Google LGTM Approval of a pull request to be merged into the repository label May 15, 2024
@manitgupta manitgupta removed the Google LGTM Approval of a pull request to be merged into the repository label May 15, 2024
@darshan-sj darshan-sj self-requested a review May 15, 2024 06:09
@manitgupta manitgupta changed the title Add Data type size and generated columns CUJs Add Data type size, generated columns, charset and synth_id CUJs May 15, 2024
darshan-sj
darshan-sj approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darshan-sj darshan-sj added the Google LGTM Approval of a pull request to be merged into the repository label May 17, 2024
@copybara-service copybara-service bot merged commit 6cca16f into GoogleCloudPlatform:main May 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darshan-sj darshan-sj darshan-sj approved these changes

@asthamohta asthamohta Awaiting requested review from asthamohta asthamohta is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

@VardhanThigle VardhanThigle Awaiting requested review from VardhanThigle VardhanThigle is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

Assignees
No one assigned
Labels
Google LGTM Approval of a pull request to be merged into the repository size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manitgupta @darshan-sj