Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WORKER_REGION and WORKER_ZONE to template parameter type #1553

Closed
wants to merge 3 commits into from

Conversation

Amar3tto
Copy link
Contributor

No description provided.

@Amar3tto
Copy link
Contributor Author

R: @an2x

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 40.96%. Comparing base (82dfb0b) to head (34d8c2b).

Current head 34d8c2b differs from pull request most recent head 466e970

Please upload reports for the commit 466e970 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1553      +/-   ##
============================================
+ Coverage     40.83%   40.96%   +0.13%     
+ Complexity     2834     2808      -26     
============================================
  Files           743      739       -4     
  Lines         43183    42889     -294     
  Branches       4610     4584      -26     
============================================
- Hits          17633    17571      -62     
+ Misses        24044    23817     -227     
+ Partials       1506     1501       -5     
Components Coverage Δ
spanner-templates 59.84% <ø> (+0.23%) ⬆️
spanner-import-export 65.57% <ø> (+1.11%) ⬆️
spanner-live-forward-migration 73.67% <ø> (+0.03%) ⬆️
spanner-live-reverse-replication 48.64% <ø> (-0.03%) ⬇️
spanner-bulk-migration 78.01% <ø> (-0.02%) ⬇️
Files Coverage Δ
...gle/cloud/teleport/metadata/TemplateParameter.java 0.00% <ø> (ø)
...le/cloud/teleport/metadata/util/MetadataUtils.java 43.05% <100.00%> (+1.62%) ⬆️
.../teleport/plugin/model/ImageSpecParameterType.java 100.00% <100.00%> (ø)
...loud/teleport/plugin/model/ImageSpecParameter.java 34.57% <85.71%> (+1.97%) ⬆️

... and 45 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant