Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupName attribute to v2 template where it's needed (part 2) #1541

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

akashorabek
Copy link
Contributor

No description provided.

@akashorabek akashorabek marked this pull request as ready for review May 10, 2024 05:20
@akashorabek akashorabek requested a review from a team as a code owner May 10, 2024 05:20
@akashorabek akashorabek requested review from asthamohta and VardhanThigle and removed request for a team May 10, 2024 05:20
@Amar3tto
Copy link
Contributor

Currently in process of fixing, in accordance with the comments from #1542

@Amar3tto
Copy link
Contributor

PR is ready for review

@liferoad liferoad requested a review from an2x May 23, 2024 13:09
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.36%. Comparing base (896b33b) to head (c888f78).
Report is 41 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1541      +/-   ##
============================================
- Coverage     41.37%   41.36%   -0.02%     
- Complexity     2917     3185     +268     
============================================
  Files           752      752              
  Lines         43839    43839              
  Branches       4685     4685              
============================================
- Hits          18138    18133       -5     
- Misses        24167    24168       +1     
- Partials       1534     1538       +4     
Components Coverage Δ
spanner-templates 61.05% <ø> (-0.05%) ⬇️
spanner-import-export 64.34% <ø> (-0.11%) ⬇️
spanner-live-forward-migration 73.39% <ø> (ø)
spanner-live-reverse-replication 48.62% <ø> (ø)
spanner-bulk-migration 81.77% <ø> (ø)
Files Coverage Δ
...leport/v2/auto/blocks/PubsubMessageToTableRow.java 0.00% <ø> (ø)
.../cloud/teleport/v2/auto/blocks/ReadFromPubSub.java 0.00% <ø> (ø)
...cloud/teleport/v2/auto/blocks/WriteToBigQuery.java 0.00% <ø> (ø)
...e/cloud/teleport/v2/auto/blocks/WriteToPubSub.java 0.00% <ø> (ø)
...cloud/teleport/v2/auto/dlq/WriteDlqToBigQuery.java 0.00% <ø> (ø)
.../cloud/teleport/v2/templates/PubSubToBigQuery.java 34.67% <ø> (ø)
...ogle/cloud/teleport/v2/templates/PubsubToAvro.java 11.62% <ø> (ø)
.../cloud/teleport/v2/templates/TextIOToBigQuery.java 68.00% <ø> (ø)
...leport/v2/templates/pubsubtotext/PubsubToText.java 0.00% <ø> (ø)
...v2/transforms/WriteDataChangeRecordsToGcsAvro.java 90.32% <ø> (ø)
... and 7 more

... and 1 file with indirect coverage changes

@an2x an2x added the Google LGTM Approval of a pull request to be merged into the repository label Jun 5, 2024
@copybara-service copybara-service bot merged commit 0da6c1e into GoogleCloudPlatform:main Jun 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Google LGTM Approval of a pull request to be merged into the repository size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants