-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add groupName attribute to v2 template where it's needed (part 2) #1541
Merged
copybara-service
merged 3 commits into
GoogleCloudPlatform:main
from
akvelon:BIDI-115-part-2
Jun 6, 2024
Merged
Add groupName attribute to v2 template where it's needed (part 2) #1541
copybara-service
merged 3 commits into
GoogleCloudPlatform:main
from
akvelon:BIDI-115-part-2
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashorabek
requested review from
asthamohta and
VardhanThigle
and removed request for
a team
May 10, 2024 05:20
Currently in process of fixing, in accordance with the comments from #1542 |
PR is ready for review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1541 +/- ##
============================================
- Coverage 41.37% 41.36% -0.02%
- Complexity 2917 3185 +268
============================================
Files 752 752
Lines 43839 43839
Branches 4685 4685
============================================
- Hits 18138 18133 -5
- Misses 24167 24168 +1
- Partials 1534 1538 +4
|
an2x
approved these changes
May 29, 2024
an2x
added
the
Google LGTM
Approval of a pull request to be merged into the repository
label
Jun 5, 2024
copybara-service
bot
merged commit Jun 6, 2024
0da6c1e
into
GoogleCloudPlatform:main
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.