Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database/influxdb2): Add database support of influxdb2 client #203

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

genofire
Copy link
Member

@genofire genofire commented May 27, 2021

Description

Major changes happens in InfluxDB on version 2, lets update the API dependencies.

Motivation and Context

fixes #202

Checklist:

  • My code follows the code style of this project.
  • I have added also tests for my new code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

config_example.toml Outdated Show resolved Hide resolved
lemoer added a commit to freifunkh/ansible that referenced this pull request Sep 19, 2021
@skorpy2009
Copy link
Contributor

Hey @genofire konntest du dir das nochmal anschauen?

@corny corny force-pushed the main branch 7 times, most recently from 7352bd1 to ff42378 Compare March 28, 2022 02:21
@genofire genofire force-pushed the influxdb2 branch 7 times, most recently from 0dcd55a to f3d6a68 Compare April 14, 2022 06:51
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #203 (1a552f2) into main (22f67e2) will decrease coverage by 6.89%.
The diff coverage is 14.81%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   73.11%   66.22%   -6.89%     
==========================================
  Files          55       59       +4     
  Lines        2418     2742     +324     
==========================================
+ Hits         1768     1816      +48     
- Misses        598      872     +274     
- Partials       52       54       +2     
Files Changed Coverage Δ
database/influxdb2/global.go 0.00% <0.00%> (ø)
database/influxdb2/link.go 0.00% <0.00%> (ø)
database/influxdb2/node.go 0.00% <0.00%> (ø)
database/influxdb2/database.go 60.00% <60.00%> (ø)

@genofire genofire force-pushed the influxdb2 branch 2 times, most recently from 086d875 to 55b22b2 Compare September 16, 2023 23:40
@genofire genofire changed the title [TASK] Inital support of influxdb2 client feat(database/influxdb2): Add database support of influxdb2 client Sep 17, 2023
@AiyionPrime
Copy link
Contributor

AiyionPrime commented Sep 17, 2023

@genofire We've just deployed v1.3.2, one local patch to omit duplicate node warnings and this PRs commit. @1977er just confirmed we're running and getting data again.

@genofire
Copy link
Member Author

genofire commented Sep 17, 2023

greate, hope i do not drift away, and maybe write testcases, then i could merge it :)

here i found fakeclient: https://github.com/influxdata/influxdb-client-go/blob/master/internal/examples/fakeclient.go

!!! warning
yanic do NOT prune nodes data (so please setup it in InfluxDB2 setup).

We hightly recommend to setup e.g. [Data retention](https://docs.influxdata.com/influxdb/v2/reference/internals/data-retention/) in InfluxDB2 server per measurements.
Copy link
Member Author

@genofire genofire Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AiyionPrime, @1977er and @maurerle do you have example code, to setup such data retention?

Do you like to give feedback about my documentation?

@genofire genofire force-pushed the influxdb2 branch 2 times, most recently from 76b7360 to 472aa22 Compare September 18, 2023 20:13
Copy link
Contributor

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the docs.

I currently can't test this due to time constraints.

docs/docs/configuration.md Outdated Show resolved Hide resolved
docs/docs/configuration.md Show resolved Hide resolved
global = "yanic"
#firmware = "yanic-temp"
#model = "yanic-temp"
#autoupdater = "yanic-temp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the default documentation show that all measurements are written?

Copy link
Member Author

@genofire genofire Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it yo bucket_default = yanic and here global = yanic-persistent ... good point

docs/docs/configuration.md Show resolved Hide resolved
docs/docs/configuration.md Outdated Show resolved Hide resolved
docs/docs/configuration.md Outdated Show resolved Hide resolved
docs/docs/configuration.md Outdated Show resolved Hide resolved
docs/docs/configuration.md Outdated Show resolved Hide resolved
docs/docs/configuration.md Outdated Show resolved Hide resolved
@genofire
Copy link
Member Author

Thank you for your review :)

@herbetom
Copy link

What is the state of this PR?

@AiyionPrime are you still using this (and also in the current version?)? Have you had any problem?

@AiyionPrime
Copy link
Contributor

I think so. Will check after work. Maybe not today; we'll be climbing until late.

@herbetom
Copy link

herbetom commented Feb 26, 2024

After reading a bit more about influxdb i'm not quite sure wheter v2 is even the way to go with it seemingly already beeing more or less in the same somewhat abandoned state as v1 and v3 beeing yet another rewrite.

@1977er
Copy link

1977er commented Feb 26, 2024

@AiyionPrime are you still using this (and also in the current version?)? Have you had any problem?

This is what "we" are using with influx2. Not sure, if this is that. No current problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Influx 2.0
8 participants