BIM: Allow to export groups as assemblies #14094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the original behaviour be proposed to BuildingSmart (?) for consideration? |
|
@paullee0 it could, but I fear it has zero chances to give any result now while they don't see a use case. The idea here is to allow people to play with it and maybe when we have a more serious "case" to propose... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a discussion on https://community.osarch.org/discussion/comment/20540#Comment_20540 , it appears what we are currently doing at FreeCAD, that is, aggregating groups inside a building structure, is illegal.
With this PR, groups nested inside building structures will now by default be exported as IfcElementAssemblies.
However, since we (okay, I) firmly believe groups nested inside building structures are a good idea, and so far most BIM apps have no problems with it, there is an option under Edit -> Preferences -> I/O -> IFC export to disable this and get back to the previous behaviour (groups exported as IfcGroups and aggregated). This option is clearly marked as non-standard compliant.