feature: allocate message_id in mail from: phase #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pulled it sucessfully, I'll run it against my local testsuite first before pushing it to master |
bjne
force-pushed
the
experimental_mailfrom_msgid
branch
2 times, most recently
from
4a0bd06
to
904ac9d
Compare
Added EXPERIMENTAL_MAILFROM_MSGID to move generation of message_id from DATA to MAIL FROM phase. This will allow logging of errors in RCPT phase, referencing a potential future message_id
bjne
force-pushed
the
experimental_mailfrom_msgid
branch
from
904ac9d
to
665485e
Compare
|
He Bjne, after long delay I'm continuing now the integration of your work. |
|
rebased it to current master, now I'll check how it passes the testsuite run |
|
It still breaks the testsuite run, even if the EXPERIMENTAL_MAILFROM_MSGID is disabled, which, IMHO should not happen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EXPERIMENTAL_MAILFROM_MSGID to move generation of message_id
from DATA to MAIL FROM phase. This will allow logging of errors
in RCPT phase, referencing a potential future message_id