Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Create MyEddieHubContribution #10284

Closed
wants to merge 4 commits into from

Conversation

DGRYZER
Copy link

@DGRYZER DGRYZER commented Mar 14, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few changes required to merge this PR:

  • File must be data directory
  • Filename must be exact same as your GitHub username.
  • We don't need type, displayStatsPublic, and avatar key anymore, so remove line no: 4, 5, 6
  • Choose a valid icon from the icons list available here for line no: 11

Let us know if you need any help with these. Please follow these quickstart docs or you can create a new PR by starting over from the beginning if it sounds too complex to you, just follow above mentioned step-by-step guide.

@kumarsonsoff3 kumarsonsoff3 added the ✍ chore: profile This label will be added on PR with request of Data json addition label Mar 18, 2024
@github-actions github-actions bot removed the ✍ chore: profile This label will be added on PR with request of Data json addition label Mar 18, 2024
@kumarsonsoff3 kumarsonsoff3 added the ✍ chore: profile This label will be added on PR with request of Data json addition label Mar 18, 2024
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already suggested, your file must be in data directory & filename must be exactly same as your GitHub username. Please rename your file here to data/DGRYZER.json

Change MyEddieHubContribution --> data/DGRYZER.json

@github-actions github-actions bot removed the ✍ chore: profile This label will be added on PR with request of Data json addition label Apr 21, 2024
@eddiejaoude
Copy link
Member

Review changes not made and PR has been open for a long time, so I will close this PR

@eddiejaoude eddiejaoude closed this Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants