Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Fix: 8824 Edit Icon Alignment fix in the links page. #10227

Merged
merged 13 commits into from
Jun 8, 2024

Conversation

hi-Kartik2004
Copy link
Contributor

@hi-Kartik2004 hi-Kartik2004 commented Feb 8, 2024

Fixes Issue

Closes #8824

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

How it will look after merging this PR

image

How it looks now

image

Note to reviewers

This modification does not impact other pages using the Edit component as the component now accepts a new prop i.e className for modifications instead of changing the exisiting classes.

@SaraJaoude SaraJaoude added the issue linked Pull Request has issue linked label Feb 13, 2024
@SaraJaoude
Copy link
Member

Please take into consideration the comments here.

components/user/UserLink.js Show resolved Hide resolved
components/user/UserLink.js Show resolved Hide resolved
@eddiejaoude eddiejaoude changed the base branch from main to contributions June 8, 2024 10:39
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great collaboration 👍

@eddiejaoude eddiejaoude merged commit 4568001 into EddieHubCommunity:contributions Jun 8, 2024
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Edit button on manage links page looks out of place
5 participants