Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove spaces to match new helper events in 2023.5 #546

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LordSushiPhoenix
Copy link

@LordSushiPhoenix LordSushiPhoenix commented May 5, 2023

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Breaking change

If your PR contains a breaking change for existing users, it is important to describe what breaks, how to make it work again and why we did this. This section will be used to craft the changelog entry, after your PR gets approved and merged.

Note: Remove this section if this PR is NOT a breaking change.

May break compatibility with Home Assistant versions before 2023.5

Proposed change*

Describe the big picture of your changes here, and why your pull request should be accepted. If it fixes a bug or resolves a feature request, be sure to put closes #XXXX in this section to auto-close relevant issues.

Please note that for important and breaking changes it's always better to open an issue first for discussing the proposal.

Make sure to provide enough information so that your pull request can be reviewed.

The last controller event format has changed in 2023.5 and broken some controller automations. Removing spaces fixes it. Mentioned in #543, but I don't expect these changes to affect the SNZB-01.

#544 (comment)
#543 (comment)

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Hey @LordSushiPhoenix, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Copy link

@rubinho76 rubinho76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done this modification in ikea_e1744.yaml and it works.

@tumtumsback
Copy link

I did this modification in ikea_e1743.yaml and it did NOT work.

In ikea_e1743.yaml, these would be lines 280 and 281. I replaced the old lines with the new lines, restarted home assistant, but still no dice.

@thomas-svrts
Copy link

thomas-svrts commented May 7, 2023

@rubinho76 I also changed my e1744 yaml, but didnt succeeded. Can you share your changes?
I changed this part:
IMG_4320

@tumtumsback
Copy link

tumtumsback commented May 7, 2023

@rubinho76 I also changed my e1744 yaml, but didnt succeeded. Can you share your changes? I changes this part: IMG_4320

Right? Lol ... What magic trick did @rubinho76 use? I literally copied the entire new raw YAML from @LordSushiPhoenix overtop of the original YAML and still no dice...

@LordSushiPhoenix
Copy link
Author

@rubinho76 I also changed my e1744 yaml, but didnt succeeded. Can you share your changes? I changes this part: IMG_4320

Right? Lol ... What magic trick did @rubinho76 use? I literally copied the entire new raw YAML from @LordSushiPhoenix overtop of the original YAML and still no dice...

if you copied the entire ikea_e2001_e2002.yaml file into your ikea_e1744.yaml that is likely why it didn't work. The two files are different before modification, and replacing the e1744 yaml with the e2001_e2002 yaml replaces the logic with logic for a different controller. Even e1743 and e1744 are different.

@tumtumsback
Copy link

tumtumsback commented May 7, 2023 via email

@rubinho76
Copy link

@rubinho76 I also changed my e1744 yaml, but didnt succeeded. Can you share your changes? I changed this part: IMG_4320

I have only taken over the modifications, i.e. removed the spaces. Everything else is still original.

@jpa00
Copy link

jpa00 commented May 13, 2023

If I may, I would suggest instead considering the spaces optional (followed by ? in the regex), to both keep compatibility with old style messages and make the check a little bit less fragile to possible future changes. That said, using regex to check a JSON format message is pretty fragile by nature.

@dealeros
Copy link

Thanks @LordSushiPhoenix ! It fixed my issues with BUFFER_FULL in zigbee2MQTT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants