Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setValue ts interface support recur path #2245

Merged
merged 6 commits into from
May 24, 2024

Conversation

pointhalo
Copy link
Collaborator

@pointhalo pointhalo commented May 20, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

#1737
#2243
实现如下类型提示,setValue 入参若为嵌套路径,对合法性进行校验。对不合法的key进行错误提示

image
image

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@pointhalo
Copy link
Collaborator Author

该PR不需要跟 v2.59 release。后续我单独发alpha给用户验证后再合入。

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (08c76a5) to head (3aa6fb4).

Current head 3aa6fb4 differs from pull request most recent head 17d7950

Please upload reports for the commit 17d7950 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2245      +/-   ##
==========================================
- Coverage   88.16%   88.14%   -0.02%     
==========================================
  Files         440      440              
  Lines       26057    26057              
  Branches     6651     6651              
==========================================
- Hits        22972    22967       -5     
- Misses       3085     3090       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 17d7950:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented May 21, 2024

Passing run #2503 ↗︎

0 259 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 17d7950 into 08c76a5...
Project: semi-design Commit: 3aa6fb4bb0 ℹ️
Status: Passed Duration: 10:52 💡
Started: May 21, 2024 6:27 AM Ended: May 21, 2024 6:38 AM

Review all test suite changes for PR #2245 ↗︎

@pointhalo pointhalo merged commit 599618a into main May 24, 2024
9 checks passed
@pointhalo pointhalo deleted the chore-setValueRecurPath branch May 24, 2024 10:38
@rojer95
Copy link
Contributor

rojer95 commented May 26, 2024

image

貌似最新版不写泛型情况下,会变成这样。。。

@pointhalo
Copy link
Collaborator Author

image

貌似最新版不写泛型情况下,会变成这样。。。

get。本地测试没有考虑到。我再看下怎么改改(囧,类型体操还是略繁琐)

pointhalo added a commit that referenced this pull request May 29, 2024
…2259)

* fix: fix type error when formApi not pass generics, #2245
* chore: improve getValue type
* chore: add export FieldPathValue type
@pointhalo
Copy link
Collaborator Author

image

貌似最新版不写泛型情况下,会变成这样。。。

v2.59.1 已fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants