Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(new tool): Json to Go #1031

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(new tool): Json to Go #1031

wants to merge 1 commit into from

Conversation

sharevb
Copy link
Contributor

@sharevb sharevb commented May 1, 2024

Fix #655. Taken from #732

@vercel Vercel
Copy link

vercel bot commented May 1, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview May 15, 2024 9:05pm

@sharevb sharevb mentioned this pull request May 5, 2024
Open
@sharevb sharevb marked this pull request as ready for review May 5, 2024 22:00
CorentinTh
CorentinTh approved these changes May 10, 2024
View reviewed changes
Copy link
Owner

@CorentinTh CorentinTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

Can you please add some happy-path unit test of this service ?

I don't really want untested, copy pasted source in the app, it's not future proof and can lead to regression issues + it will help if someone want to rewrite it better (400+ lines function full of closure that mute vars 🤮 )

CorentinTh
CorentinTh requested changes May 10, 2024
View reviewed changes
Copy link
Owner

@CorentinTh CorentinTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, missed-click

@sharevb
Copy link
Contributor Author

sharevb commented May 10, 2024

Thanks for the PR

Can you please add some happy-path unit test of this service ?

I don't really want untested, copy pasted source in the app, it's not future proof and can lead to regression issues + it will help if someone want to rewrite it better (400+ lines function full of closure that mute vars 🤮 )

Yes, right, i will rewrite using https://www.npmjs.com/package/json-to-go, unit tested

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sharevb
Copy link
Contributor Author

sharevb commented May 15, 2024

Hi @CorentinTh, made unit tests

@sharevb sharevb requested a review from CorentinTh May 15, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CorentinTh CorentinTh Awaiting requested review from CorentinTh

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON-to-Go
2 participants
@sharevb @CorentinTh