Add page for evals with packets opened in the past semester #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galenguyer
force-pushed
the
past-packets
branch
from
7641db3
to
54e90d1
Compare
galenguyer
force-pushed
the
past-packets
branch
from
54e90d1
to
9006bb2
Compare
mxmeinhold
reviewed
Oct 3, 2022
| @before_request | ||
| @log_time | ||
| def admin_past_packets(info=None): | ||
| open_packets = Packet.opened_after(datetime.date.today() - datetime.timedelta(days=(30 * 4))) |
There was a problem hiding this comment.
30*4? does conditional do any awareness of what the current semester is that we could throw a rough start date here?
There was a problem hiding this comment.
or is this intended to be "recent"?
future: wonder if evals would like a date selector
| @@ -26,7 +26,8 @@ | |||
| </a> | |||
| <div class="dropdown-menu" aria-labelledby="navbarDropdownMenuLink"> | |||
| <a class="dropdown-item" href="{{ url_for("admin_freshmen") }}">Freshmen</a> | |||
| <a class="dropdown-item" href="{{ url_for("admin_packets") }}">Packets</a> | |||
| <a class="dropdown-item" href="{{ url_for("admin_packets") }}">Active Packets</a> | |||
| <a class="dropdown-item" href="{{ url_for("admin_past_packets") }}">Past Packets</a> | |||
There was a problem hiding this comment.
nit: should this be Recent Packets?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.