-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly fallback during backup copy #64153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-1
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
May 20, 2024
This is an automated comment for commit f610af5 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
antonio2368
force-pushed
the
fix-backup-without-native-copy
branch
from
May 21, 2024 08:36
de46c32
to
d66f0d6
Compare
antonio2368
force-pushed
the
fix-backup-without-native-copy
branch
from
May 21, 2024 11:29
06a963c
to
b80d878
Compare
vitlibar
reviewed
May 24, 2024
vitlibar
reviewed
May 24, 2024
vitlibar
reviewed
May 24, 2024
antonio2368
force-pushed
the
fix-backup-without-native-copy
branch
from
May 27, 2024 13:02
100c73b
to
8f77503
Compare
vitlibar
approved these changes
May 27, 2024
antonio2368
added
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
labels
May 28, 2024
This was referenced May 28, 2024
This was referenced May 28, 2024
robot-clickhouse
added a commit
that referenced
this pull request
May 28, 2024
…df375b0554d48b14574ad4e9051f7 Cherry pick #64153 to 24.5: Correctly fallback during backup copy
robot-clickhouse
added a commit
that referenced
this pull request
May 28, 2024
robot-ch-test-poll4
added a commit
that referenced
this pull request
May 28, 2024
Backport #64153 to 24.5: Correctly fallback during backup copy
robot-ch-test-poll
added a commit
that referenced
this pull request
May 29, 2024
…df375b0554d48b14574ad4e9051f7 Cherry pick #64153 to 24.2: Correctly fallback during backup copy
robot-clickhouse
added a commit
that referenced
this pull request
May 29, 2024
robot-ch-test-poll
added a commit
that referenced
this pull request
May 29, 2024
…df375b0554d48b14574ad4e9051f7 Cherry pick #64153 to 24.3: Correctly fallback during backup copy
robot-clickhouse
added a commit
that referenced
this pull request
May 29, 2024
robot-ch-test-poll
added a commit
that referenced
this pull request
May 29, 2024
…df375b0554d48b14574ad4e9051f7 Cherry pick #64153 to 24.4: Correctly fallback during backup copy
robot-clickhouse
added a commit
that referenced
this pull request
May 29, 2024
robot-ch-test-poll
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
May 29, 2024
robot-ch-test-poll1
added a commit
that referenced
this pull request
May 29, 2024
Backport #64153 to 24.4: Correctly fallback during backup copy
robot-ch-test-poll1
added a commit
that referenced
this pull request
May 29, 2024
Backport #64153 to 24.2: Correctly fallback during backup copy
robot-ch-test-poll1
added a commit
that referenced
this pull request
May 29, 2024
Backport #64153 to 24.3: Correctly fallback during backup copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix creating backups to S3 buckets with different credentials from the disk containing the file.
If native copy was disabled or it failed for some known reasons, native copy will fallback to copying using read/write. The problem was that we created both buffers using same client while their credentials could differ.
cc @vitlibar
Documentation entry for user-facing changes
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: