Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): apt-get Missing '-y' To Avoid Manual Input #7060

Merged
merged 29 commits into from
Jun 7, 2024
Merged

fix(query): apt-get Missing '-y' To Avoid Manual Input #7060

merged 29 commits into from
Jun 7, 2024

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented May 17, 2024 •
edited

Closes #7053

Reason

  • Bug found where some flags that avoid manual input weren't being taken into consideration by the query;
  • This threw false positive results;
  • New flags to add: --yes, --assume-yes, -qq, --quiet --quiet, -q=2, -q -q;

Proposed Changes

  • add more flags that avoid manual input;
  • add unit tests for the new flags;
  • fix typos on queries expected and actual results message;
  • change query's folder name, name and description to better reflect it's behaviour.

APPSEC-2556

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the query New query feature label May 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

kics-logo

KICS version: v2.0.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX self-assigned this May 17, 2024
@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review May 20, 2024 11:45
@github-actions github-actions bot added the bug Something isn't working label May 27, 2024
cx-ruiaraujo
cx-ruiaraujo approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@cx-ruiaraujo cx-ruiaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 🙌

@cx-andrep cx-andrep merged commit 7fff702 into master Jun 7, 2024
26 checks passed
@cx-andrep cx-andrep deleted the AST-42923 branch June 7, 2024 11:33
@ArturRibeiro-CX ArturRibeiro-CX mentioned this pull request Jun 7, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-ruiaraujo cx-ruiaraujo cx-ruiaraujo approved these changes

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx

@cxMiguelSilva cxMiguelSilva Awaiting requested review from cxMiguelSilva

@JoaoCxMartins JoaoCxMartins Awaiting requested review from JoaoCxMartins

@EduardoSemanas EduardoSemanas Awaiting requested review from EduardoSemanas

@asofsilva asofsilva Awaiting requested review from asofsilva

@cx-andrep cx-andrep Awaiting requested review from cx-andrep

Assignees

@ArturRibeiro-CX ArturRibeiro-CX

Labels
bug Something isn't working query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(dockerfile): apt-get Missing '-y' To Avoid Manual Input`
3 participants
@ArturRibeiro-CX @cx-ruiaraujo @cx-andrep