Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): implicit flow in oauth2 queries duplicated #7057

Merged
merged 20 commits into from
Jun 11, 2024
Merged

fix(query): implicit flow in oauth2 queries duplicated #7057

merged 20 commits into from
Jun 11, 2024

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented May 16, 2024 •
edited

Reason

  • Duplicated queries with the same logic, one needs to be deleted;

Proposed Changes

  • delete newest query Implicit Flow query in OAuth2 (v3);
  • add new unit tests to OAuth2 With Implicit Flow query;
  • improve phrasing of actual and expected results;

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the query New query feature label May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

kics-logo

KICS version: v2.0.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review May 16, 2024 10:49
cx-ruiaraujo
cx-ruiaraujo approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@cx-ruiaraujo cx-ruiaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 🙌

@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner June 11, 2024 15:54
@cx-andrep cx-andrep merged commit e83ddfc into master Jun 11, 2024
28 checks passed
@cx-andrep cx-andrep deleted the AST-40742 branch June 11, 2024 16:20
@BrewTestBot BrewTestBot mentioned this pull request Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-ruiaraujo cx-ruiaraujo cx-ruiaraujo approved these changes

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx

@cxMiguelSilva cxMiguelSilva Awaiting requested review from cxMiguelSilva

@JoaoCxMartins JoaoCxMartins Awaiting requested review from JoaoCxMartins

@EduardoSemanas EduardoSemanas Awaiting requested review from EduardoSemanas

@asofsilva asofsilva Awaiting requested review from asofsilva

@cx-andrep cx-andrep Awaiting requested review from cx-andrep

Assignees
No one assigned
Labels
query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArturRibeiro-CX @cx-ruiaraujo @cx-andrep