Improve Font Rendering for Japanese Language #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaiJimmy
requested changes
Sep 2, 2023
assets/scss/variables.scss
Outdated
| } | ||
|
|
||
| body:lang(zh) { | ||
| --base-font-family: var(--zh-font-family), var(--sys-font-family), var(--cjk-font-family), sans-serif; |
There was a problem hiding this comment.
I'm not really sure about this value.
I would write:
--base-font-family: "Lato", var(--sys-font-family), var(--zh-font-family), var(--cjk-font-family), sans-serif;
So:
- Lato is used for the Latin alphabet
- In case Lato is not available, use
--sys-font-family(which is optimized for the Latin alphabet) - For CJK text, it won't match any of the previous cases, so it will try to use
--zh-font-familyand succeed.
The same rule applies to ja. It's important to have "Lato" in the first place, otherwise the Latin alphabet would use the CJK font and look really bad.
Does that make sense to you?
There was a problem hiding this comment.
Thank you for your review, and I apologize for the delayed response.
Your comments were correct, so I have made the necessary revisions.
You might notice several push --force operations, which occurred due to my unfamiliarity with GitHub.
Please note that these do not affect the content of the commits.
f-matano44
force-pushed
the
add-cjk-font
branch
from
94b657d
to
d8e8159
Compare
f-matano44
force-pushed
the
add-cjk-font
branch
from
d8e8159
to
21da06e
Compare
f-matano44
force-pushed
the
add-cjk-font
branch
2 times, most recently
from
6ff3b65
to
3ceb679
Compare
f-matano44
force-pushed
the
add-cjk-font
branch
from
3ceb679
to
3167461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to improve the display of Japanese text on the website.
Changes made:
The new font family list prioritizes commonly available and high-quality fonts for Japanese text, such as "Hiragino Kaku Gothic ProN", "Meiryo", and "Noto Sans CJK JP". These changes will help to ensure that our Japanese text is displayed accurately and beautifully across various operating systems and browsers.
Please review the changes and let me know if any adjustments are needed.