Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator: replace <boost/random.hpp> with <random> #8207

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

afabri
Copy link
Member

@afabri afabri commented May 16, 2024

Summary of Changes

Replace boost:: version with std:: version.

  • replace boost:: with std:: for binomial_distribution, geometric_distribution, uniform_real_distribution
  • replace boost::rand48 with std::mt19937
  • remove boost::variate_generator

We still have from boost: random_number_generator, uniform_int, uniform_small_int, uniform_real, uniform_01, boost::lagged_fibonacci607 ,

Release Management

  • Affected package(s): Generator
  • Issue(s) solved (if any): fix warnings in the testsuite
  • License and copyright ownership: unchanged

@sloriot sloriot force-pushed the CGAL-binomial_distribution-GF branch from d5d24da to 88b1877 Compare May 21, 2024 16:10
@lrineau lrineau added this to the 6.1-beta milestone May 21, 2024
@lrineau
Copy link
Member

lrineau commented May 21, 2024

Unless there is an important need, this PR will be for CGAL-6.1.x.

@lrineau
Copy link
Member

lrineau commented May 21, 2024

Are there consequences in the CGAL documentation?

@afabri afabri changed the title Generator: replace boost:: with std:: binomial_distribution Generator: replace <boost/random.hpp> with <random> May 22, 2024
@afabri
Copy link
Member Author

afabri commented May 22, 2024

@janetournois do you know why you use the boost::lagged_fibonacci607 generator

@afabri
Copy link
Member Author

afabri commented May 23, 2024

Are there consequences in the CGAL documentation?

Yes, And dealt with for example in Random.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants