-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Triangulation on Sphere: Fix I/O #8201
Open
afabri
wants to merge
8
commits into
CGAL:5.5.x-branch
Choose a base branch
from
afabri:ToS-IO-GF
base: 5.5.x-branch
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afabri
added
Bug
Pkg::Hyperbolic_triangulation_2
Pkg::Triangulation_on_sphere_2
and removed
Pkg::Hyperbolic_triangulation_2
labels
May 14, 2024
afabri
changed the title
Triangulation on Sphere: Fix I/O
WIP Triangulation on Sphere: Fix I/O
May 14, 2024
afabri
changed the title
WIP Triangulation on Sphere: Fix I/O
Triangulation on Sphere: Fix I/O
May 14, 2024
MaelRL
added
the
Not yet approved
The feature or pull-request has not yet been approved.
label
May 15, 2024
@MaelRL can you have a look at the assertion. My guess is that the |
As you expect still some error in ToS tests of CGAL-6.0-Ic-245
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Not yet approved
The feature or pull-request has not yet been approved.
Pkg::Triangulation_on_sphere_2
Ready to be tested
Tests failing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add test case that illustrates Issue #8200.
Todo
ToS2::is_valid()
which does not compile (it is inoperator>>(..)
)skip_vertex
Release Management