Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangulation on Sphere: Fix I/O #8201

Open
wants to merge 8 commits into
base: 5.5.x-branch
Choose a base branch
from
Open

Conversation

afabri
Copy link
Member

@afabri afabri commented May 14, 2024

Summary of Changes

Add test case that illustrates Issue #8200.

Todo

  • Fix ToS2::is_valid() which does not compile (it is in operator>>(..))
  • Fix skip_vertex
  • Check why ghost faces are not the same after writing and reading back.

Release Management

@afabri afabri self-assigned this May 14, 2024
@afabri afabri added this to the 6.0-beta milestone May 14, 2024
@afabri afabri changed the title Triangulation on Sphere: Fix I/O WIP Triangulation on Sphere: Fix I/O May 14, 2024
@afabri afabri changed the title WIP Triangulation on Sphere: Fix I/O Triangulation on Sphere: Fix I/O May 14, 2024
@afabri afabri requested a review from MaelRL May 14, 2024 13:57
@afabri afabri marked this pull request as ready for review May 14, 2024 14:05
@afabri afabri changed the base branch from master to 5.5.x-branch May 14, 2024 15:01
@MaelRL MaelRL added the Not yet approved The feature or pull-request has not yet been approved. label May 15, 2024
@MaelRL MaelRL modified the milestones: 6.0-beta, 5.5.5 May 15, 2024
@afabri
Copy link
Member Author

afabri commented May 16, 2024

@MaelRL can you have a look at the assertion. My guess is that the is_valid() function has a bug, as it did not even compile before I started this pull request.

@sloriot
Copy link
Member

sloriot commented May 21, 2024

As you expect still some error in ToS tests of CGAL-6.0-Ic-245

   ERROR:      execution   of  issue_8200 in 0.0147595 s : Failed 
CGAL error: assertion violation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Triangulation on Sphere: operator>>
3 participants