Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OpenTelemetry integration so traces include path #2835

Open
SimunKaracic opened this issue May 8, 2024 · 2 comments
Open

Improve OpenTelemetry integration so traces include path #2835

SimunKaracic opened this issue May 8, 2024 · 2 comments
Labels
💎 Bounty enhancement New feature or request

Comments

@SimunKaracic
Copy link

Is your feature request related to a problem? Please describe.
When using the OTEL agent with ZIO-http, we get the benefit of existing Netty instrumentation. This means traces are started/stopped and propagated correctly, but there's a problem.
The server trace names contain only the HTTP method (which is useless, we need the route in the trace name).

From what I can tell, we're hitting the same issue as described here open-telemetry/opentelemetry-java-instrumentation#8613

We need to add instrumentation to the OTEL agent that provides the span name.
This involves hooking into specific classes and methods in ZIO-http.

Describe the solution you'd like
Someone from the core team decides if there's enough stability in the internal API to hook into it with the OTEL java agent.

And if there is, you can provide me the classes/methods where I can see the matched route and I'll try and add the required instrumentation to OTEL.

Describe alternatives you've considered
Someone from the core team writes a plugin and I don't have to do anything? :D

@SimunKaracic SimunKaracic added the enhancement New feature or request label May 8, 2024
@SimunKaracic SimunKaracic changed the title Improve OpenTelemetry integration so traces include path. Improve OpenTelemetry integration so traces include path May 8, 2024
@jdegoes
Copy link
Member

jdegoes commented Jun 4, 2024

/bounty $150

Copy link

algora-pbc bot commented Jun 4, 2024

💎 $150 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #2835 with your implementation plan
  2. Submit work: Create a pull request including /claim #2835 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-http!

Add a bountyShare on socials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants