Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoints from cases classes where the last field is an Option[Int] or Option[Long] result in BadRequest #2766

Closed
russwyte opened this issue Apr 10, 2024 · 4 comments
Labels
💎 Bounty bug Something isn't working

Comments

@russwyte
Copy link
Contributor

Describe the bug
Endpoints from cases classes where the last field is an Option[Int] or Option[Long] result in BadRequest when the request body is pretty printed json.

To Reproduce
See this issue and PR

That PR should be acted on and a new version of zio-schema should be released this project should update its dependency to reflect the new version.

Expected behaviour
Valid and correctly encoded JSON should not result in BadRequest.

Screenshots
If applicable, add screenshots to help explain your problem.

@jdegoes
Copy link
Member

jdegoes commented Jun 5, 2024

/bounty $150 for fixing this, either here or in upstream, and adding test here to ensure it works.

Copy link

algora-pbc bot commented Jun 5, 2024

💎 $150 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #2766 with your implementation plan
  2. Submit work: Create a pull request including /claim #2766 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-http!

Add a bountyShare on socials

@russwyte
Copy link
Contributor Author

russwyte commented Jun 5, 2024

@jdegoes I actually fixed the root cause (via zio-schema PR) here:

@russwyte russwyte closed this as completed Jun 5, 2024
@russwyte
Copy link
Contributor Author

russwyte commented Jun 5, 2024

Here is the upstream fix
zio/zio-schema#676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants