Fix Windows #211
Merged
Fix Windows #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuanqing this is ready (no more commits expected) Verified on a Windows machine with all overrides present. |
|
I need this, please |
| @@ -16,6 +18,8 @@ import { importFresh } from '../import-fresh.js' | |||
| import { esbuildCssModulesPlugin } from './esbuild-css-modules-plugin.js' | |||
| import { esbuildPreactCompatPlugin } from './esbuild-preact-compat-plugin.js' | |||
|
|
|||
| const isWindows = platform() === 'win32' | |||
There was a problem hiding this comment.
This is probably a dumb question, as I haven't done any platform-specific node development, but I assume this is win32 even on 64-bit OSes?
|
@yuanqing Can we please get this PR merged? It's a major blocker in upgrading to the newest version for windows users |
|
@TheUltDev – Thanks for this! I’ve merged but made a small change to move the logic into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205.
This change appends the
file://protocol to windows paths to the error below(technically we let
pathToFileURLfromnode:urldo the work)