Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lack of result checking for hex.DecodeString in many places. #1112

Open
ufm opened this issue Dec 1, 2023 · 0 comments
Open

lack of result checking for hex.DecodeString in many places. #1112

ufm opened this issue Dec 1, 2023 · 0 comments

Comments

@ufm
Copy link
Contributor

ufm commented Dec 1, 2023

If an empty string is passed to hex.DecodeString, it returns an empty string. Upon a cursory examination of the source code, it is evident that this is not checked anywhere. As a result, amusing messages like the following can occur:"

yggdrasilctl debug_remotegetself key=
Admin socket returned an error: timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ufm