-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaLinks Extension doesn't work on relative links #715
Comments
For reference here's a screen shot of Markdown Monster rendering the above links as well as a relative image and an explicit HTML video tag: For the markdown media links only the online However the manual video link work fine with a relative path for image rendered out of the current path (cut off bottom image is a video player instance). |
Medialinks extension only supports absolute URL. It could support relative with an option to allow them. |
Do you think relative paths need an option? Seems like this should just work otherwise it's confusing why some media links work and some do not. Looks like the only other parser that actually supports media link parsing (on Babelmark) is PanDoc. PanDoc turns relative paths into respective If I find some time I'll take a look. |
Problem is more backward compatibility that could start to break existing code that were relying on this behavior. |
It appears that the
.UseMediaLinks()
extension does not detect media when the URL is not an http link, but rather a relative path.The following demonstrates:
Note that the only media link created correctly is the one that has the full HTTP link while the relative link/no path ones render as images which is not correct.
Here's a Gist with the above code:
https://gist.github.com/RickStrahl/36035c87787fc24e37861059e40a6f8b
The text was updated successfully, but these errors were encountered: