Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

developer-experience: deployment previews for pull requests #3924

Closed
hydrosquall opened this issue May 19, 2024 · 0 comments · Fixed by #3925
Closed

developer-experience: deployment previews for pull requests #3924

hydrosquall opened this issue May 19, 2024 · 0 comments · Fixed by #3925
Assignees
@hydrosquall
Labels
feature-request For requesting new features or transforms

Comments

@hydrosquall
Copy link
Member

hydrosquall commented May 19, 2024 •
edited

Enhancement Description

Goal: Reduce time and effort to validate change requests, and improve review quality for vegachange requests (PRs). By making a deployment preview easy, it is easier to test user facing behaviors. Similar to vega/vega-lite#9276

Motivating use-cases

Expected behavior

  • When a new PR is opened, build a copy of the vega vega/editor that uses this branch's copy of vega

Notes
@hydrosquall hydrosquall added the feature-request For requesting new features or transforms label May 19, 2024
@hydrosquall hydrosquall self-assigned this May 19, 2024
@hydrosquall hydrosquall mentioned this issue May 19, 2024
Merged
hydrosquall added a commit that referenced this issue May 24, 2024
@hydrosquall
build: add deploy preview of the Vega editor (#3925)
11a33fb 
## Motivation

- Fix #3924

## Changes

- Set explicit yarn and node versions so that the build step can succeed
in Cloudflare CI
- Move installing data out of the postinstall as it was causing the
initial install to break. I moved it to a docs building step
- Add a build script for setting up a site deploy preview

## Testing

<img width="1464" alt="image"
src="https://github.com/vega/vega/assets/9020979/62fed5ec-ff0d-45b2-9e23-08dc0d82241b">

- Visit the preview URL:
https://cameron-yick-deploy-previews.vega-628.pages.dev/
- Check that console logs from both `vega` and a subpackage like
`vega-view` are both visible.
  - (I'll remove these statements before merging)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hydrosquall hydrosquall

Labels
feature-request For requesting new features or transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: add deploy preview of the Vega editor vega/vega
1 participant
@hydrosquall