Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix all symbols #46

Open
agx opened this issue Nov 5, 2023 · 1 comment
Open

Prefix all symbols #46

agx opened this issue Nov 5, 2023 · 1 comment
Milestone
v1.9.1

Comments

@agx
Copy link
Contributor

agx commented Nov 5, 2023

There's some symbols that neither use the vm_, varnam_ or vararray_ prefix: see https://github.com/anoop142

It would be good to namespace those before the next release as we can't drop symbols afterwards and we're polluting the namespace for other libs linked by programs otherwise.

Midterm it would make sense to prefix all symbols with a single prefix (e.g. varnam_ or just v_) and bump the soname once.
agx referenced this issue in anoop142/govarnam Nov 5, 2023
@anoop142
exported symbols: avoid wildcard
92c3c65 
* export specific symbols instead of destroy* wildcard
* order symbols alphabetically

Thanks @agx for suggestions.
@agx agx mentioned this issue Nov 5, 2023
Open
@subins2000
Copy link
Member

@agx What is the the best ideal solution for a library, all exported symbols having the same prefix? Or is it fine to have symbols with multiple common prefixes? I was looking at libvarnam's debian packaging attempt and there are a LOT on the list: https://github.com/varnamproject/packaging/blob/master/libvarnam/debian/libvarnam.symbols

@subins2000 subins2000 modified the milestones: v2.0.0, v1.9.1 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.1
Development

No branches or pull requests
2 participants
@agx @subins2000