weather_owm module: switch to 3.0 API endpoint as 2.5 is deprecated #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasers
reviewed
May 18, 2024
ultrabug
force-pushed
the
issue_2246
branch
2 times, most recently
from
b3dc8a8
to
d108c5a
Compare
ultrabug
changed the title
|
@mlmatlock hi, I'd appreciate a last check please |
@ultrabug works fine with the old (2.5) API key. Trying with a 3.0 (generated 10 May 2024) key gives an "Error 401". If I try calling the 2.5 API (from a browser) with the 3.0 key,
the resulting error message is:
|
|
Ok thanks @mlmatlock there's nothing more this PR can do about that. I added a comment on the module, will merge when CI is green! |
|
released in 3.58! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2246