Remove 8.8.8.8 and instead determine the local IP for each packet #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![prplex[bot]](https://avatars.githubusercontent.com/in/353986?s=60&v=4){kind=small}
| @@ -1884,7 +1884,8 @@ void satip_server_rtsp_init | |||
| reg = 1; | |||
| } | |||
| s = rtsp_ip; | |||
| rtsp_ip = strdup(bindaddr); | |||
| if(bindaddr != NULL) | |||
There was a problem hiding this comment.
Ensure that bindaddr is checked for null before calling strdup. This ensures that the function does not crash if bindaddr is null.
There was a problem hiding this comment.
Thats.... uhmmm... literally what I am doing?
Flole998
force-pushed
the
remove8888
branch
5 times, most recently
from
3d2bfaf
to
323c51c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs testing
Fixes: #1634