[BUG]: Multi-Client SAT>IP unsubscribe causes crash if the order is different from the subscribing order

[Flole998]

Tvheadend Version

v4.3 (development)

Build Number

4.3.2209

Platform

Ubuntu 22.04 (Jammy)

Architecture

Intel x86_64

Category

Crashes

Description

The issue is occuring if 2 SAT>IP clients watch the same encrypted channel and they unsubscribe in a different order than they subscribed, so like this:

Client 1 subscribes

Client 2 subscribes

Client 1 unsubscribes

(Tvheadend marks the raw service it created initially for deletion and then deletes it, however that service is still used by client 2 as client 2 has it still set as s_master, but the deleted raw service doesn't have any s_client entries at deletion anymore, I verified that. At this point Client 2 no longer gets any MPEG-TS packets.)

Client 2 unsubscribes

(Tvheadend crashes)

I tried to add more debug output and make sense of the linking of the different services but just couldn't figure out how it's supposed to work, the client services seem to somehow link to each other or something like that?

Logfile

No response

Reproduction

No response