Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not deploy metrics and tracing Helm charts by default #4

Open
kevinpollet opened this issue Jul 22, 2020 · 4 comments
Open

Do not deploy metrics and tracing Helm charts by default #4

kevinpollet opened this issue Jul 22, 2020 · 4 comments
Labels
kind/proposal a proposal that needs to be discussed.

Comments

@kevinpollet
Copy link
Member

Feature Request

Proposal

Currently, the metrics and tracing sub-charts are deployed by default on Maesh installation. The purpose of the Helm chart is to install Maesh and to provide the necessary configuration options to be able to use supported metrics and tracing libraries, and not to provide production-ready stacks for metrics and tracing.

Therefore, the metrics and tracing sub-charts must not be deployed by default but should be kept for testing and demonstration purposes.

@kevinpollet
Copy link
Member Author

@SantoDE @jspdown Thoughts?

@jspdown
Copy link

jspdown commented Jul 23, 2020

I agree with this proposal but it's remains important to provide working and meaningful configurations for metrics and tracing. I suggest to put these files in a contrib folder like on Traefik

@kevinpollet
Copy link
Member Author

For now, I would just keep the Helm chart as is and disable the deployment by default. I also agree that we should find a way to distribute configurations for common tools, like grafana.

@kevinpollet kevinpollet transferred this issue from traefik/mesh Sep 21, 2020
@kevinpollet kevinpollet added the kind/proposal a proposal that needs to be discussed. label Sep 21, 2020
@acamilleri
Copy link

Prometheus and Grafana each have an operator to configure them.
You can maybe offer the possibility to deployed grafana dashboard and prometheus job as CRD, in case of the user have installed Prometheus and Grafana with operators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/proposal a proposal that needs to be discussed.
Projects
None yet
Development

No branches or pull requests

3 participants