Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sushi changing SRT File Encoding #31

Open
Asinin3 opened this issue Jul 11, 2018 · 2 comments
Open

Sushi changing SRT File Encoding #31

Asinin3 opened this issue Jul 11, 2018 · 2 comments

Comments

@Asinin3
Copy link

Asinin3 commented Jul 11, 2018

When I ran Sushi with SRT subtitles that were encoded as UTF-8-BOM Sushi saved the output subtitles as simply UTF-8. When trying to open this file in Aegisub it gave the following error:
image
This is easily fixed by changing the encoding of the file. Weirdly enough, this only seems to happen on SRT subtitles, when I ran Sushi on .ass subtitles which used UTF-8-BOM it did not change the encoding.
Here's the original and sushi output if needed:
sushi.zip

@Asinin3
Copy link
Author

Asinin3 commented Nov 1, 2018

As an update, this doesn't happen on all SRT files, only some. I'm not sure what's causing it to happen with the file I provided though.

@averms
Copy link

averms commented Nov 4, 2018

According to subs.py your first comment is in line with the source.
It writes utf-8 when dealing with srt, and utf-8-sig when dealing with ass.
I will open up a pull request to change that behavior.

As an update, this doesn't happen on all SRT files, only some.

Interesting... can you please provide files to reproduce?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants