Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce using either tabs or spaces, at least on a per-file basis #881

Open
ahelwer opened this issue Feb 20, 2024 · 1 comment
Open

Enforce using either tabs or spaces, at least on a per-file basis #881

ahelwer opened this issue Feb 20, 2024 · 1 comment

Comments

@ahelwer
Copy link
Contributor

ahelwer commented Feb 20, 2024

Similar to #872 some of the files in this repo use tabs, other use spaces, some use tabs on some lines & spaces on other lines in the same file, and some mix tabs & spaces on the same line. It doesn't really matter whether tabs or spaces are used as long as the decision is uniform and consistent; ideally this would be uniform across the entire repo, but some method should be used to enforce this on a per-file basis at least. As with the LF/CRLF issue any such change should be done incrementally over time to avoid spurious diffs confusing debugging, but at very least a decision should be made and this process should be started.

One good concrete action would be to add a step to the PR CI which analyzes any new files to enforce that they are entirely tabs or entirely spaces (ideally we would enforce one), so at least the situation does not get worse, and ideally would check that for each file modified, if it previously was entirely tabs or spaces, the modifications do not change that.

@ahelwer ahelwer changed the title Enforce using either tabs or spaces, at least on a per-file bases Enforce using either tabs or spaces, at least on a per-file basis Feb 20, 2024
@kape1395
Copy link

I would vote for spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants