PCmanFM-Qt overlaps screen #1

PCmanFM-Qt 0.16.0 run with --desktop overlaps the entire i3 screen including i3bar. The behavior resembles that of an unpatched version of i3, but the window additionally steals keyboard input, not allowing to spawn a new terminal to kill it or switch workspaces.

This doesn't reproduce with the original PCmanFM.

xprop with PCmanFM-Qt:

~ > sleep 10 && xprop
_NET_WM_ICON_NAME(UTF8_STRING) =
XdndAware(ATOM) = BITMAP
WM_NAME(STRING) =
_NET_WM_NAME(UTF8_STRING) = "pcmanfm-qt"
_MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x2, 0x1, 0x0, 0x0, 0x0
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_DESKTOP
_XEMBED_INFO(_XEMBED_INFO) = 0x0, 0x1
WM_CLIENT_LEADER(WINDOW): window id # 0x7e00008
WM_HINTS(WM_HINTS):
                Client accepts input or input focus: True
                window id # of group leader: 0x7e00008
WM_CLIENT_MACHINE(STRING) = "haseul"
_NET_WM_PID(CARDINAL) = 128076
_NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 132120583
WM_CLASS(STRING) = "pcmanfm-qt", "pcmanfm-qt"
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST
WM_NORMAL_HINTS(WM_SIZE_HINTS):
                user specified location: 0, 0
                user specified size: 1920 by 1080
                program specified minimum size: 73 by 73
                window gravity: Static

For PCmanFM 1.3.1 the output is as follows:

~ > sleep 10 && xprop
_NET_WM_STATE(ATOM) = _NET_WM_STATE_SKIP_TASKBAR, _NET_WM_STATE_SKIP_PAGER
WM_HINTS(WM_HINTS):
                Client accepts input or input focus: True
                Initial state is Normal State.
                window id # of group leader: 0x7e00001
XdndAware(ATOM) = BITMAP
_MOTIF_DRAG_RECEIVER_INFO(_MOTIF_DRAG_RECEIVER_INFO) = 0x6c, 0x0, 0x5, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x10, 0x0, 0x0, 0x0
_NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 132120581
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_DESKTOP
_NET_WM_USER_TIME_WINDOW(WINDOW): window id # 0x7e00004
WM_CLIENT_LEADER(WINDOW): window id # 0x7e00001
_NET_WM_PID(CARDINAL) = 128674
WM_LOCALE_NAME(STRING) = "en_US.UTF-8"
WM_CLIENT_MACHINE(STRING) = "haseul"
WM_NORMAL_HINTS(WM_SIZE_HINTS):
                program specified location: 0, 0
                program specified minimum size: 1920 by 1080
                program specified maximum size: 1920 by 1080
                window gravity: NorthWest
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST
WM_CLASS(STRING) = "pcmanfm", "Pcmanfm"
WM_ICON_NAME(STRING) = "pcmanfm"
_NET_WM_ICON_NAME(UTF8_STRING) = "pcmanfm"
WM_NAME(STRING) = "pcmanfm"
_NET_WM_NAME(UTF8_STRING) = "pcmanfm"

Originally reported by mid-kid through https://aur.archlinux.org/pkgbase/i3-gaps-desktop/

PCmanFM-Qt 0.16.0 run with `--desktop` overlaps the entire i3 screen including i3bar. The behavior resembles that of an unpatched version of i3, but the window additionally steals keyboard input, not allowing to spawn a new terminal to kill it or switch workspaces. This doesn't reproduce with the original PCmanFM. `xprop` with PCmanFM-Qt: ``` ~ > sleep 10 && xprop _NET_WM_ICON_NAME(UTF8_STRING) = XdndAware(ATOM) = BITMAP WM_NAME(STRING) = _NET_WM_NAME(UTF8_STRING) = "pcmanfm-qt" _MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x2, 0x1, 0x0, 0x0, 0x0 _NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_DESKTOP _XEMBED_INFO(_XEMBED_INFO) = 0x0, 0x1 WM_CLIENT_LEADER(WINDOW): window id # 0x7e00008 WM_HINTS(WM_HINTS): Client accepts input or input focus: True window id # of group leader: 0x7e00008 WM_CLIENT_MACHINE(STRING) = "haseul" _NET_WM_PID(CARDINAL) = 128076 _NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 132120583 WM_CLASS(STRING) = "pcmanfm-qt", "pcmanfm-qt" WM_PROTOCOLS(ATOM): protocols WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST WM_NORMAL_HINTS(WM_SIZE_HINTS): user specified location: 0, 0 user specified size: 1920 by 1080 program specified minimum size: 73 by 73 window gravity: Static ``` For PCmanFM 1.3.1 the output is as follows: ``` ~ > sleep 10 && xprop _NET_WM_STATE(ATOM) = _NET_WM_STATE_SKIP_TASKBAR, _NET_WM_STATE_SKIP_PAGER WM_HINTS(WM_HINTS): Client accepts input or input focus: True Initial state is Normal State. window id # of group leader: 0x7e00001 XdndAware(ATOM) = BITMAP _MOTIF_DRAG_RECEIVER_INFO(_MOTIF_DRAG_RECEIVER_INFO) = 0x6c, 0x0, 0x5, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x10, 0x0, 0x0, 0x0 _NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 132120581 _NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_DESKTOP _NET_WM_USER_TIME_WINDOW(WINDOW): window id # 0x7e00004 WM_CLIENT_LEADER(WINDOW): window id # 0x7e00001 _NET_WM_PID(CARDINAL) = 128674 WM_LOCALE_NAME(STRING) = "en_US.UTF-8" WM_CLIENT_MACHINE(STRING) = "haseul" WM_NORMAL_HINTS(WM_SIZE_HINTS): program specified location: 0, 0 program specified minimum size: 1920 by 1080 program specified maximum size: 1920 by 1080 window gravity: NorthWest WM_PROTOCOLS(ATOM): protocols WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST WM_CLASS(STRING) = "pcmanfm", "Pcmanfm" WM_ICON_NAME(STRING) = "pcmanfm" _NET_WM_ICON_NAME(UTF8_STRING) = "pcmanfm" WM_NAME(STRING) = "pcmanfm" _NET_WM_NAME(UTF8_STRING) = "pcmanfm" ``` Originally reported by **mid-kid** through https://aur.archlinux.org/pkgbase/i3-gaps-desktop/

The patches from https://github.com/h0cheung/i3-gaps-kde/blob/gaps-kde/src/manage.c#L295 might do the trick.

This specifically addresses https://git.tdem.in/tdemin/i3/src/branch/desktop_window_patch/src/manage.c#L241 to also stack the desktop window below others with XCB.

Fixed by #4.