Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4029: Add debug flag for delr page empty trace #4068

Merged

Conversation

LivingLimes
Copy link
Contributor

@LivingLimes LivingLimes commented May 19, 2024

Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.

What is the motivation?

Hide unwanted trace from release build to minimise logging noise.

What does this change do?

Hide unwanted trace from release build using debug flag.

What is your testing strategy?

Tested manually via the following steps:

  1. Start app with in memory db in release mode:
cargo watch -x 'run --no-default-features --features storage-mem,http,scripting --release -- start --log trace --user root --pass root memory'
  1. Import data into the in memory db (this is required so that there are things for the db to garbage collect, else the function that calls this trace will not appear). I used the first 100 lines from the demo data.
cargo run -- import --conn http://localhost:8000 --user root --pass root --ns test --db test ~/Downloads/surreal-deal-v2.surql
  1. Observe traces
    Without the code change:
( tv_sec 221093, tv_nsec 488276916

With the code change:
image

(I added a trace _delr called to be sure the function was being called.)

Is this related to any issues?

Closes #4029

Does this change need documentation?

If this pull request requires changes, updates, or improvements to the documentation, then add a corresponding issue on the docs.surrealdb.com repository, and link to it here.

Have you read the Contributing Guidelines?

@LivingLimes LivingLimes marked this pull request as ready for review May 20, 2024 07:40
@LivingLimes LivingLimes requested a review from a team as a code owner May 20, 2024 07:40
@phughk
Copy link
Contributor

phughk commented May 20, 2024

Thanks for fixing this :) Looking for next ticket

@phughk phughk enabled auto-merge May 21, 2024 12:55
@phughk phughk added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 21, 2024
@tobiemh tobiemh added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 21, 2024
@phughk phughk added this pull request to the merge queue May 21, 2024
Merged via the queue into surrealdb:main with commit 140e709 May 21, 2024
22 checks passed
@LivingLimes LivingLimes deleted the bugfix-4029-remove-delr-from-release-trace branch May 22, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Delr is displayed in trace logs of releases
3 participants