Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong mapping of field names to their index for DelimitedRowFilter #440

Open
loquisgon opened this issue Apr 4, 2023 · 5 comments
Open
Labels
wontfix This will not be worked on

Comments

@loquisgon
Copy link
Contributor

When using a DelimitedRowFilter and the input schema has fields that are not in alphabetical order then the Schema will be configured with the wrong fieldName to indexPositionForField mapping. That is, imagine your schema is XField:Long, AField:Float, BField:String then the mapping that will be produced is AField:Long, BField:Float, XField:String which is wrong.

To Reproduce
See unit test in #439.

@loquisgon
Copy link
Contributor Author

This was blocking my use case, I built a new connector based on this patch and my use case now is unblocked. It'd be great to put this into a release soon (the PR referenced above).

@fhussonnois
Copy link
Member

Hi @loquisgon, thanks for your PR. I've made a review on it. Could you please check the requested changes so that I can merge your fix ?

Thank you

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Jul 6, 2023
@theworkshopcom
Copy link

The above fix, seems to be duplicating all fields on the list while re-adding them.

We have raised an improvement based on the suggested implementation on #534 FYI @fhussonnois @loquisgon

@github-actions github-actions bot removed the wontfix This will not be worked on label Sep 14, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants