-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong mapping of field names to their index for DelimitedRowFilter #440
Comments
This was blocking my use case, I built a new connector based on this patch and my use case now is unblocked. It'd be great to put this into a release soon (the PR referenced above). |
Hi @loquisgon, thanks for your PR. I've made a review on it. Could you please check the requested changes so that I can merge your fix ? Thank you |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
The above fix, seems to be duplicating all fields on the list while re-adding them. We have raised an improvement based on the suggested implementation on #534 FYI @fhussonnois @loquisgon |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
When using a
DelimitedRowFilter
and the input schema has fields that are not in alphabetical order then the Schema will be configured with the wrong fieldName to indexPositionForField mapping. That is, imagine your schema is XField:Long, AField:Float, BField:String then the mapping that will be produced is AField:Long, BField:Float, XField:String which is wrong.To Reproduce
See unit test in #439.
The text was updated successfully, but these errors were encountered: