Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade between images #47

Open
colejd opened this issue Mar 13, 2020 · 3 comments
Open

Fade between images #47

colejd opened this issue Mar 13, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@colejd
Copy link
Contributor

colejd commented Mar 13, 2020

When the image changes, it's a pretty jarring snap between the two. It'd be nice to have fading between them as an option.

@colejd colejd added the enhancement New feature or request label Mar 13, 2020
@sindresorhus
Copy link
Owner

By "image", I assume you mean "website". And yes, this is planned. We need to change it so that Plash loads the new website in a new hidden web view, and if it succeeds, we fade it in over the existing web view, and then close the existing web view. That would create a seamless experience.

@colejd
Copy link
Contributor Author

colejd commented Sep 25, 2020

This appears to be a duplicate of #9.

@sindresorhus
Copy link
Owner

@colejd Not really. #9 is about fading in the initial load of the web view. That's very easy. Just need to animate it after detecting it's done loading. This issue is about fading when navigating, which means we need two make two web views and fade between them. This issue could potentially surpass #9, but #9 would be easier to do in the short-term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants