-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Create CI job to have an automated check that fails if a pattern file has an issue, model data missing, etc. (mesheryctl or etc.) #111
Comments
Hey @MarioArriaga92, I am working on it and I tried by making some changes to it locally. |
|
Hey @professorabhay are you working on this? |
I do not see any PR in https://github.com/service-mesh-patterns/service-mesh-patterns/pulls yet though |
Hi @MarioArriaga92, Yes, I've worked on it. I created a template with some defined steps, but there are still some things that need further refinement. I also require some guidance, as I'm a beginner. I've provided the file content above. Could you please take a look at it? |
@professorabhay can you please visit https://github.com/service-mesh-patterns/service-mesh-patterns/pulls and create new PR? The screenshot you shared makes it clear you've created a PR against your own fork, not against the upstream repo (service-mesh-patterns/service-mesh-patterns). |
Current Behavior
During today's Meshery Build & Release meeting, @theBeginner86 shared with audience there was a problem when he tried to test IstioSpire design in PR #109 because Custom Resource wasn't being handled properly in the UI:
Desired Behavior
Since resolution is that there was a "bug" in the updates made to the samples/IstioSPIRE.yaml pattern file itself the suggestion is if we can create a Github Workflow CI job so we can smoke test changes made to these sample files in an automated and standard fashion
The idea is to simplify maintenance of sample pattern files and avoid false positive failures across meshery adapter or other CI runs across Meshery repos and end users that consume these samples.
Implementation
No idea yet but I'm sure contributors will have great recommendations here.
Acceptance Tests
Contributor Guides and Resources
The text was updated successfully, but these errors were encountered: