Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty where clauses don't have an unused warning #125242

Closed
dev-ardi opened this issue May 18, 2024 · 5 comments
Closed

Empty where clauses don't have an unused warning #125242

dev-ardi opened this issue May 18, 2024 · 5 comments
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-feature-request Category: A feature request, i.e: not implemented / a PR. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@dev-ardi
Copy link
Contributor 

fn foo() where {}
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 18, 2024
@fmease fmease added A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 18, 2024
@mu001999 mu001999 mentioned this issue May 19, 2024
Closed
@mu001999
Copy link
Contributor

By using rustfmt, we can get fn foo() {} after formatting. I think we don't need to warn more.

@dev-ardi
Copy link
Contributor Author

Not when there's a return type: fn foo() -> () where {}

@mu001999
Copy link
Contributor

@dev-ardi seems what we should do is to improve rustfmt, right?

@dev-ardi
Copy link
Contributor Author

I agree

@workingjubilee
Copy link
Contributor

It seems this was wontfixed in #125277, so I think we can close this for now! Feel free to open issues with clippy/rustfmt/tell me I'm wrong and reopen it.

@workingjubilee workingjubilee closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
@mu001999 mu001999 mentioned this issue May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-feature-request Category: A feature request, i.e: not implemented / a PR. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a new lint unneeded_where_clauses, suggests removing empty where clauses mu001999-contrib/rust
5 participants
@fmease @mu001999 @workingjubilee @dev-ardi @rustbot