-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cephfs + fscrypt in dev-env #14035
Comments
Hey @parth-gr, How does this sound and maybe a more general question if there is anyway standard how the common.yaml is kept in sync with the other repositories? If this is something that sounds good, I could go ahead with the changes |
Maybe @travisn would have some input on this? |
Yes @NymanRobin that would be a good idea. It is also good to discuss them during the community meeting, https://github.com/rook/rook?tab=readme-ov-file#community-meeting |
Good point, I will join the next community meeting @parth-gr |
@NymanRobin Are you planning to add the permissions here in the common.yaml or shall I pick it up? |
Sorry I have been busy with another "related" issue so forgot this one! Thanks for reminding me @iamniting, I will open a PR for this |
Thanks for taking this issue! Let us know if you have any questions! |
@NymanRobin make sure to have a timeline plan for completion of this. |
I opened the PR now @parth-gr, let me know if it looks good! |
Change the common.yaml to reflect recent changes in ceph-csi and allow for custom Minikube VM image.
The current clusterroles in common.yaml for cephfs-csi-nodeplugin and cephfs-external-provisioner-runner do not, out of the box, support reading secrets and/or configmaps. This does not allow for the development of CephFS + fscrypt without patching this after starting the environment.
The chart changes have been made in the ceph-csi repository here. So, I think this could be done here as well?
However, to use CephFS + fscrypt, it requires a 6.6+ kernel version, and this is not something that Minikube offers out of the box. Therefore, it would be nice to also allow the possibility of setting the iso_url in the Minikube start command through environment variables.
EDIT: Setting the minikube iso is possible through environment variable export MINIKUBE_ISO_URL="[URL/FILE}"
The text was updated successfully, but these errors were encountered: