{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":285304,"defaultBranch":"master","name":"reviewboard","ownerLogin":"reviewboard","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2009-08-22T21:39:49.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/118199?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717668136.0","currentOid":""},"activityList":{"items":[{"before":"467720a13b3840ad6165a685dfbc73f8468057f7","after":"92d6620facfd7038008d6903e71ee81a2e572104","ref":"refs/heads/release-7.x","pushedAt":"2024-06-07T19:05:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix links in the RB7 release notes and add DB warning.\n\nI missed adding the rb7 intersphinx link, so links to the RB docs from\nthe release notes weren't building. We didn't notice because prior to\nthe 7.0 release, we didn't have any RB7 docs on the website anyway.\n\nThis also adds a warning about Django's dropped DB versions like we had\nin the Djblets release notes.\n\nTesting Done:\nBuilt the release notes and checked for errors in links to public docs.\n\nReviewed at https://reviews.reviewboard.org/r/13959/","shortMessageHtmlLink":"Fix links in the RB7 release notes and add DB warning."}},{"before":"ed91aa5add1cfc689be121b4dc9ad9d47fe12a66","after":"467720a13b3840ad6165a685dfbc73f8468057f7","ref":"refs/heads/release-7.x","pushedAt":"2024-06-07T01:25:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Bump to 7.0.1 dev.","shortMessageHtmlLink":"Bump to 7.0.1 dev."}},{"before":"de7450e2a32d19f04ff796c04bbf9c3790a13e21","after":null,"ref":"refs/tags/release-7.0","pushedAt":"2024-06-06T10:02:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"}},{"before":"d57f04f0a3709f3793341fe6695226404af92245","after":"64d3ec9837ee1d7e30e3660e0bc38e5bc93672f4","ref":"refs/heads/master","pushedAt":"2024-06-06T10:01:54.000Z","pushType":"push","commitsCount":45,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge branch 'release-7.x'","shortMessageHtmlLink":"Merge branch 'release-7.x'"}},{"before":"52a55d0600d22fc998b32d9c18c9567b982e4af4","after":"ed91aa5add1cfc689be121b4dc9ad9d47fe12a66","ref":"refs/heads/release-7.x","pushedAt":"2024-06-06T09:54:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Release Review Board 7.","shortMessageHtmlLink":"Release Review Board 7."}},{"before":"f0c2966aa13b47fc922e48bfe6d1f58097567a66","after":"52a55d0600d22fc998b32d9c18c9567b982e4af4","ref":"refs/heads/release-7.x","pushedAt":"2024-06-06T05:11:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix up some issues in the Review Board manual.\n\nThis fixes up a handful of relatively small issues with the manual:\n\n- Perforce moved the documentation for stunnel to a new article.\n- We weren't including the server monitoring doc in the toctrees.\n- Said monitoring doc had a broken link to the docker install docs.\n- Django has removed the `request-middleware` and `response-middleware`\n  refs from their docs, so I reworded it to not try to link to them.\n- We weren't linking to the correct django-evolution doc location.\n- The diff commit validation resource was giving the wrong name for the\n  relevant doc ref.\n\nTesting Done:\nBuilt docs and checked links.\n\nReviewed at https://reviews.reviewboard.org/r/13951/","shortMessageHtmlLink":"Fix up some issues in the Review Board manual."}},{"before":"92a8e50cecd5b21f33bc04225aa5e87473d545f8","after":"f0c2966aa13b47fc922e48bfe6d1f58097567a66","ref":"refs/heads/release-7.x","pushedAt":"2024-06-06T05:10:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"michelle-aubin","name":"Michelle Aubin","path":"/michelle-aubin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46432749?s=80&v=4"},"commit":{"message":"Update the CI Integration docs.\n\nThis updates all of our CI integration docs according to the new changes coming\nin RB integrations 4.0.\n\nTesting Done:\nBuilt and viewed the docs in my RB6 dev tree and in RB7.\n\nReviewed at https://reviews.reviewboard.org/r/13941/","shortMessageHtmlLink":"Update the CI Integration docs."}},{"before":"32b64439c127f83f087e516a6b6d77d72fe37066","after":"92a8e50cecd5b21f33bc04225aa5e87473d545f8","ref":"refs/heads/release-7.x","pushedAt":"2024-06-06T03:45:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Update Review Board packaging to use Ink and Tabler Icons.\n\nThe `package-lock.json` now reflects the Ink dependency from Djblets,\nand locks the version for building Review Board.\n\nWe make use of Tabler icons for the Follow menu, so we now need to\ninclude this as a dependency as well.\n\nTesting Done:\nSuccessfully built packages and deployed.\n\nReviewed at https://reviews.reviewboard.org/r/13950/","shortMessageHtmlLink":"Update Review Board packaging to use Ink and Tabler Icons."}},{"before":"0ffe21fb846fe036cfe2cecda7ca6557ba882829","after":"32b64439c127f83f087e516a6b6d77d72fe37066","ref":"refs/heads/release-7.x","pushedAt":"2024-06-06T01:31:16.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix building the user manual.\n\nBuilding the user manual was hitting a problem when trying to\nserialize links for the DraftFileAttachmentResource, where it wasn't\nfinding the right review request.\n\nAfter a trip far down the rabbit hole, I narrowed this down to a bug in\ndjblets.webapi.resources.base.WebAPIResource.get_object, and the caching\nthat it does. This method attempts to keep a cache of objects, which is\nstored on the request object. Unfortunately, the cache key computation\nis broken for resources which are singleton but are children of\nnon-singleton resources. In this case, ReviewRequestDraftResource is\nmarked as singleton, but its parent resource is not singleton. We really\nought to be chaining up the tree of resources and letting each one\ncontribute to the cache key.\n\nBecause changing the cache behavior in djblets is very risky right now\n(even with a known bug of this magnitude), we're going to work around\nthis entirely in the docs code. This code exposed the bug because it\nuses the same request object for everything. In order to work around it,\nwe create new requests for each `get_queryset()` call as we iterate\nthrough the resource tree.\n\nWhile I was here I fixed up some problems I found in the fixtures with\nthe file attachment and screenshot counts, where the counts had somehow\nended up with the values typed twice (33 instead of 3, for example).\n\nTesting Done:\nBuilt user manual.\n\nReviewed at https://reviews.reviewboard.org/r/13948/","shortMessageHtmlLink":"Fix building the user manual."}},{"before":"aa511f240ecb652f82951a6166ea523c95d44c58","after":"0ffe21fb846fe036cfe2cecda7ca6557ba882829","ref":"refs/heads/release-7.x","pushedAt":"2024-06-05T05:28:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix archive and mute menu items.\n\nThe recent fix for the click handlers to menu items broke the items in\nthe archive menu, because those weren't properly converted to be\n`MenuItemAction` subclasses that implemented `activate()`. This change\ndoes that, removing the custom event handling they were doing.\n\nTesting Done:\n- Ran js-tests.\n- Verified that I could [un]archive and [un]mute from the menu items.\n- Verified that clicking on the archive menu header still toggled the\n  archive state.\n\nReviewed at https://reviews.reviewboard.org/r/13938/","shortMessageHtmlLink":"Fix archive and mute menu items."}},{"before":"31fe0b4bff151dd1ff61ca08d7f07b893c847e95","after":"aa511f240ecb652f82951a6166ea523c95d44c58","ref":"refs/heads/release-7.x","pushedAt":"2024-06-05T04:50:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix syntax highlighting issues and improve presentation in comment tooltips.\n\nThe comment tooltips shown in reviewable content was inheriting the dark\nmode styling for syntax-highlighted code in comments, which clashed with\nthe forced light-mode colors of the tooltip.\n\nWe now force the Ink theme to light mode on these tooltips, ensuring we\nget the colors we expect.\n\nWhile here, I made the tooltips a bit more readable. The style for these\nhasn't changed since Review Board 1.0. To just aid in readability some,\nand fix some regressions, I've added some standard padding along the\ntooltip, fixed the code blocks to align with the rest of the text, and\ndecreased the line height so that there aren't huge gaps. There's also\na minimum width set.\n\nI had also noticed that we had overridden a CSS variable for syntax\nhighlighting within the reviews CSS. This has been removed, ensuring\nwe're always using the theme.\n\nTesting Done:\nCreated some tooltips with paragraph content and syntax-highlighted\ncontent. Made sure that they looked correct.\n\nVerified that Python's `self` was no longer black in a code block when\nin dark mode, and instead used the syntax highlighting theme.\n\nReviewed at https://reviews.reviewboard.org/r/13936/","shortMessageHtmlLink":"Fix syntax highlighting issues and improve presentation in comment to…"}},{"before":"10bb501d126e3335d518eced478bb7df72a7ca65","after":"31fe0b4bff151dd1ff61ca08d7f07b893c847e95","ref":"refs/heads/release-7.x","pushedAt":"2024-06-05T04:42:47.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix some regressed tests for the trojan characters UI.\n\nWe renamed the CSS classes for the trojan characters notice UI, which\nregressed some unit tests. This updates the tests for the new classes.\n\nTesting Done:\nRan unit tests.\n\nReviewed at https://reviews.reviewboard.org/r/13935/","shortMessageHtmlLink":"Fix some regressed tests for the trojan characters UI."}},{"before":"637814ba31574b6afa9c93f263a2f04cef5e04eb","after":"10bb501d126e3335d518eced478bb7df72a7ca65","ref":"refs/heads/release-7.x","pushedAt":"2024-06-04T22:30:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"michelle-aubin","name":"Michelle Aubin","path":"/michelle-aubin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46432749?s=80&v=4"},"commit":{"message":"Give the review UI file attachment navigation thumbnails a higher z-index.\n\nThis gives the review UI file attachment navigation thumbnails a higher\nz-index, so that they appear on top of comments when overlapped with\nthem, instead of appearing under them.\n\nTesting Done:\nLooked at the Markdown, Text, and Image review UIs and saw that the nav\nthumbnails appeared on top of comments when they overlapped.\n\nRan JS unit tests.\n\nReviewed at https://reviews.reviewboard.org/r/13931/","shortMessageHtmlLink":"Give the review UI file attachment navigation thumbnails a higher z-i…"}},{"before":"fc4082bd558bc6ba45bdfa5818b29b10ae56a721","after":"637814ba31574b6afa9c93f263a2f04cef5e04eb","ref":"refs/heads/release-7.x","pushedAt":"2024-06-04T22:09:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"michelle-aubin","name":"Michelle Aubin","path":"/michelle-aubin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46432749?s=80&v=4"},"commit":{"message":"Fix field serialization regression and UI bug for text-based file attachment comments.\n\nThis change contains two fixes for text-based file attachment comments.\n\nFirst, we had a regression in our parsing of serialized fields. We weren't\nincluding the `viewMode` attribute in our parsed results, so it would always\nbe `null` and comments wouldn't be displayed.\n\nSecond, when building the comment bubbles that appear on the line numbers of a\nfile, we wouldn't properly calculate the comment bubble height for comments\nthat are on the view mode that is not currently visible. Now we bail if the\nview mode for the comment isn't visible, and only calculate if its visible.\n\nTesting Done:\n- Ran JS unit tests.\n- Created and viewed existing comments on a Markdown file, saw that comment\n  sizes were properly calculated.\n- Created and viewed existing comments on a .txt file, saw that comment\n  sizes were properly calculated.\n\nReviewed at https://reviews.reviewboard.org/r/13928/","shortMessageHtmlLink":"Fix field serialization regression and UI bug for text-based file att…"}},{"before":"188173d112a52c37f303787bf662475b3eba9ac6","after":"fc4082bd558bc6ba45bdfa5818b29b10ae56a721","ref":"refs/heads/release-7.x","pushedAt":"2024-06-04T04:09:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix styling of file attachment navigation and backgrounds.\n\nThe Previous/Next file navigation buttons had a few style issues on dark\nmode, some regressions, and bad interactions.\n\nThey were bunched up against the review UI, which regressed a while back\nwhen we renamed the `review-request` CSS class to `rb-c-review-request`.\nThat had intended to ensure enough space between the button and the\nreview UI, but that had broken. That spacing has been restored.\n\nThe colors used on the navigation buttons have been updated to work in\nboth light and dark modes.\n\nThumbnail backgrounds now use a darker color by default, and a matching\ntext color. This gives us text-based file attachment thumbnails that\nlook appropriate on dark mode. For consistency with rendering, we use\nthe \"diff equals\" theme color. We may want to revisit that down the road\nwhen we build a proper CSS component for thumbnails, instead picking the\ntheme color for text-based attachments only.\n\nAnd finally, an interaction issue with navigation has been fixed. We\nwere wrapping the entire attachment in an `<a href>`, but since that's\nan inherently inline element and we're putting complex block-level\nelements inside of it, the browsers are forced to try to compensate in\nsome form. They seem to do that these days by wrapping most inner\nelements with their own `<a href>`, creating a mess of styles. The end\nresult doesn't even make for a fully-clickable attachment.\n\nThe solution is the same as what we use for file attachment thumbnails\non a review request. We now have an `<a href>` overlay that sits on top\nof the whole element and consumes all click events, giving us the\nability to navigate but also to respect browser link interactions. The\nresult is a wider clickable area for navigation. This has also been made\naccessible.\n\nTesting Done:\nTested previous and next navigation in both light and dark mode, with\ndifferent types of file attachments.\n\nTested the main review request thumbnails for image-based, PDF-based,\nand text-based file attachments.\n\nReviewed at https://reviews.reviewboard.org/r/13911/","shortMessageHtmlLink":"Fix styling of file attachment navigation and backgrounds."}},{"before":"9191472f3c99d088f41a421053f91f6a35506f57","after":"188173d112a52c37f303787bf662475b3eba9ac6","ref":"refs/heads/release-7.x","pushedAt":"2024-06-04T04:08:27.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix alignment for the Enable Markdown checkbox.\n\nThe Enable Markdown checkbox in review request fields had some pretty\nbad alignment going on, creating a staggered look. We now set these to\nbe vertically aligned.\n\nTesting Done:\nTested multiple fields, making sure that the alignment was correct.\n\nReviewed at https://reviews.reviewboard.org/r/13924/","shortMessageHtmlLink":"Fix alignment for the Enable Markdown checkbox."}},{"before":"eb49c5c6804029d6a6dfc9b9e55d4bf2eb4f825d","after":"9191472f3c99d088f41a421053f91f6a35506f57","ref":"refs/heads/release-7.x","pushedAt":"2024-06-04T04:07:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add dark mode support to the New Review Request page.\n\nThe New Review Request page now works in both light and dark modes. Much\nof this is pretty straight-forward, moving to standard Ink design tokens\nfor headers, links, borders, and data tables (for the commits).\n\nThe one larger change is that the error information now uses Ink Alerts.\nThis gives a more consistent error appearance, and a more prominent\nbutton for \"Try again.\"\n\nTesting Done:\nTested the page in light and dark modes.\n\nTested repositories with and without post-commit support.\n\nTested with branch and commit errors.\n\nTested diff upload errors.\n\nTested commits already posted for review.\n\nUnit tests pass.\n\nReviewed at https://reviews.reviewboard.org/r/13912/","shortMessageHtmlLink":"Add dark mode support to the New Review Request page."}},{"before":"7384dca29af40daf4e45d478df82a14f65a2e021","after":"eb49c5c6804029d6a6dfc9b9e55d4bf2eb4f825d","ref":"refs/heads/release-7.x","pushedAt":"2024-06-04T04:06:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Revert \"Add dark mode support to the New Review Request page.\"\n\nThis reverts commit 9588e26ba412dc79842e16b483cdcd5eb5a7405e.\n\nA range of branches were accidentally landed in one change. This reverts\nthat so we can land this one-by-one.","shortMessageHtmlLink":"Revert \"Add dark mode support to the New Review Request page.\""}},{"before":"d31276d9a9cafa699e776814e4013d3736ebcc69","after":"7384dca29af40daf4e45d478df82a14f65a2e021","ref":"refs/heads/release-7.x","pushedAt":"2024-06-04T04:02:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add dark mode support and a better hit area for auto-complete menus.\n\nThe auto-complete menus were pretty much invisible on dark mode, with a\ndefault white text on a hard-coded white background.\n\nWe now use the Ink Menu color palette for the menus, giving us a\nconsistent appearance with other menus.\n\nThe standard menu item padding is also used now, giving us a larger hit\narea for the auto-complete items and better visual separation. This\nallows us to get rid of the mobile-specific styling as well.\n\nThe search results menu has also been fixed to be positioned correctly\nbelow the main navigation pane. Positioning changes had broken the\ndisplay, causing it to overlap incorrecly.\n\nTesting Done:\nTested the search results and review request auto-complete menus in\ndark and light mode, and on desktop and mobile.\n\nReviewed at https://reviews.reviewboard.org/r/13913/","shortMessageHtmlLink":"Add dark mode support and a better hit area for auto-complete menus."}},{"before":"f7f3dd7af6fefea6b9aa0c787876d8e22226c43d","after":"d31276d9a9cafa699e776814e4013d3736ebcc69","ref":"refs/heads/release-7.x","pushedAt":"2024-05-31T21:13:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"michelle-aubin","name":"Michelle Aubin","path":"/michelle-aubin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46432749?s=80&v=4"},"commit":{"message":"Update the Review Board logo URL that we suggest to upload to MS Teams in the docs.\n\nWhen setting up a Microsoft Teams integration, admins need to create an\nincoming WebHook via the Microsoft Teams app. When creating the WebHook, you\nhave the ability to upload a picture to associate with all messages coming\nfrom the WebHook (basically an avatar).\n\nSince we don't have control over this, we offer a link to a Review Board logo\nin our docs that admins can upload. This logo differs from our normal logo by\nbeing centered, so that it looks nice in the rounded crop that most chat\napplications use for avatars. We recently added this centered logo to our\nCDN, so this updates the docs to use the right URL for the centered logo.\n\nTesting Done:\nAccessed the URL and made sure it lead to the centered logo.\n\nReviewed at https://reviews.reviewboard.org/r/13916/","shortMessageHtmlLink":"Update the Review Board logo URL that we suggest to upload to MS Team…"}},{"before":"e48193851d9253706d3d770ba21cfde7ba64ac3c","after":"f7f3dd7af6fefea6b9aa0c787876d8e22226c43d","ref":"refs/heads/release-7.x","pushedAt":"2024-05-30T17:09:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"michelle-aubin","name":"Michelle Aubin","path":"/michelle-aubin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46432749?s=80&v=4"},"commit":{"message":"Add more default columns to the base review request datagrid.\n\nThis adds the Ship It/Issue counts and New Updates columns to the defaults\nfor the base review request datagrid, which is used for the All Review Requests\npage. I debated adding the My Comments column too but decided against it.\nI felt that it was too personal and that the All Review Requests page should\ndefault to just general information instead.\n\nI also audited the columns we have for the dashboard.\n\nTesting Done:\n- Saw the new columns added to the All Review Requests page (while logged in\nand logged out)\n- Saw that the columns on the dashboard appeared as normal\n- Ran unit tests.\n\nReviewed at https://reviews.reviewboard.org/r/13909/","shortMessageHtmlLink":"Add more default columns to the base review request datagrid."}},{"before":"b11f9001e33d52881998f5eb1497354f1e5aac2c","after":"e48193851d9253706d3d770ba21cfde7ba64ac3c","ref":"refs/heads/release-7.x","pushedAt":"2024-05-30T07:36:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Convert the review request field changes to modern CSS components.\n\nThe lists of changed fields on a \"review request changed\" box was\nancient, with spacing and font size inconsistencies, mobile issues, no\naccessibility affordances, and some regressions with recent styling\nchanges.\n\nThis has been redone, as a sort of first pass that we can build upon in\nthe future. We now have two new components we can use:\n\n* `rb-c-review-request-changed-fields`: The container for the entire\n  list of changed fields in the entry box, managing overall layout and\n  the styling for inner value types.\n\n* `rb-c-review-request-changed-value`: An old/new diff display for a\n  single simple field value, such as Branch, Summary, or Depends On.\n\nThe `rb-c-review-request-changed-fields` component is a definition list\nconsisting of field names and their value changes. It uses CSS grid to\ndo the layout, in a responsive manner. Subgrids are employed when\nsupported by the browser in order to help all fields line up correctly\n(without it, we use a minimum width to achieve a similar effect).\n\nThere's now one of these lists instead of many, which can help with\nnavigating using assistive technologies. We also make use of ARIA labels\nthroughout this.\n\n`rb-c-review-request-changed-value` works as the old field changes did\nbefore, but is slightly polished in that it's now less boxy, employing a\nsoft rounded border.\n\nThe changed fields component optimistically aligns the labels and values\nwith a baseline. This works great for the changed value component and\nother simple text-based value representations. However, in an effort to\nproperly align things, special rules for certain value components are\nadded. This gives us alignment for diffed text displays, file attachment\nthumbnails, and the commits list.\n\nField changes were made to aid in this and to help with consistency:\n\n* File attachments now have a parent container that we can set to be a\n  flexbox.\n* Status now says \"Completed\" instead of \"Closed (submitted)\".\n\nSome fields (namely file attachment captions) still need a lot of love,\nbut that's for another release.\n\nThe overall presentation, while resembling what we had before, is now\nmuch more polished, and will be easier to work with going forward.\n\nTesting Done:\nTested in Chrome and Firefox in light and dark modes.\n\nTested with and without subgrid support (by altering the name checked\nby `@support`), and on mobile. Verified the presentation was correct\nin each case.\n\nTested every field type in all the above cases.\n\nReviewed at https://reviews.reviewboard.org/r/13907/","shortMessageHtmlLink":"Convert the review request field changes to modern CSS components."}},{"before":"9b94626ceba1c23db6dea19b70c95ead07ce2183","after":"b11f9001e33d52881998f5eb1497354f1e5aac2c","ref":"refs/heads/release-7.x","pushedAt":"2024-05-29T23:02:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Consolidate review request UI CSS imports to an index.less.\n\nThe files in `css/ui/review-request/` and `css/ui/reviews/` were being\nimported into the bundle individually, which gave us two paths to deal\nwith any time we wanted to add a new file.\n\nWe now provide `index.less` files in both directories, which contain the\nimports for that directory, giving the bundle one place exactly to\nimport from.\n\nThere are plenty of remaining problems with our CSS directory layout,\nbut those are for another time.\n\nTesting Done:\nSuccessfully built the CSS.\n\nReviewed at https://reviews.reviewboard.org/r/13904/","shortMessageHtmlLink":"Consolidate review request UI CSS imports to an index.less."}},{"before":"c92cbf8f1b0a3d70b67636a22bad490ebd4b8488","after":"9b94626ceba1c23db6dea19b70c95ead07ce2183","ref":"refs/heads/release-7.x","pushedAt":"2024-05-29T23:00:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix a regressed test for the text Review UI.\n\nThe recent change to the tabs for the text Review UI regressed one of\nour js-tests. This change fixes it up for the new element classes.\n\nTesting Done:\nRan js-tests.\n\nReviewed at https://reviews.reviewboard.org/r/13910/","shortMessageHtmlLink":"Fix a regressed test for the text Review UI."}},{"before":"84c4fe93c65d0bbf49e3199c3c9ebfd5d0f05bae","after":"c92cbf8f1b0a3d70b67636a22bad490ebd4b8488","ref":"refs/heads/release-7.x","pushedAt":"2024-05-29T22:59:52.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Update rb-c-alert to use ink-c-alert's visuals.\n\nWe have code that uses `rb-c-alert`, and will continue to through\nrelease. To help keep things looking consistent, this change updates the\ncolors and the icons to match the visuals of `ink-c-alert`.\n\nTesting Done:\nTested all alert types in light and dark mode (initially as part of the\ndiff file notice change, before a new approach was taken), and verified\nthat the right icons and colors were used.\n\nReviewed at https://reviews.reviewboard.org/r/13903/","shortMessageHtmlLink":"Update rb-c-alert to use ink-c-alert's visuals."}},{"before":"7884d78320ad2f9d8ab7ab893cbc739f5c8f9531","after":"84c4fe93c65d0bbf49e3199c3c9ebfd5d0f05bae","ref":"refs/heads/release-7.x","pushedAt":"2024-05-29T06:13:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix over-eager deletion with drafts.\n\nWhen I added change descriptions and diffsets to the draft deletion\nhandler, I wasn't thinking about how we delete the draft after\npublishing it. In that case, we've assigned the change description to\nthe review request, and assigned the diffset to the history, but we\nhaven't cleared them from the draft object. We were therefore deleting\nthe data right after we published it.\n\nThis change fixes that up to properly check that those objects are no\nlonger alive.\n\nUnit tests have been added for this case with both of those as well as\nfile attachments, which didn't have this same problem because of the way\nwe calculate the file attachment state.\n\nTesting Done:\n- Ran unit tests.\n- Published a new review request that included a diff and saw that my\n  diff wasn't immediately deleted.\n\nReviewed at https://reviews.reviewboard.org/r/13905/","shortMessageHtmlLink":"Fix over-eager deletion with drafts."}},{"before":"da15d94c590ac080db6a18e1347cf9829221cd2e","after":"7884d78320ad2f9d8ab7ab893cbc739f5c8f9531","ref":"refs/heads/release-7.x","pushedAt":"2024-05-29T05:12:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix auth page description text color in dark mode.\n\nAuthentication pages were hard-coding a color for paragraph text in the\nauth header. This wasn't noticible on most of the auth pages, because\nwhen people are logged out, we show the default light theme. For\nweb-based RBTools authentication, we do have pages that the user could\nsee in dark mode. This change fixes it to use the `--ink-p-fg-weak`\ncolor instead.\n\nTesting Done:\nWas able to see description text for the web-based login pages.\n\nReviewed at https://reviews.reviewboard.org/r/13894/","shortMessageHtmlLink":"Fix auth page description text color in dark mode."}},{"before":"cafe4e13f133f0f135240186ec38b56f3b66e74e","after":"da15d94c590ac080db6a18e1347cf9829221cd2e","ref":"refs/heads/release-7.x","pushedAt":"2024-05-28T19:32:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge branch 'release-6.x' into release-7.x","shortMessageHtmlLink":"Merge branch 'release-6.x' into release-7.x"}},{"before":"f680802a68f6f73172e782ff8a96958815c2f95e","after":"a4c946aa4fa608ff419ee1f8c09f6660653a3933","ref":"refs/heads/release-6.x","pushedAt":"2024-05-28T19:32:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix installing Perforce in Docker.\n\nThe logic added to install Perforce in Docker didn't work correctly, for\na couple of reasons.\n\nFirst, we were basing our logic off of the build machine's architecture,\nnot the target architecture. When cross-building for X86 on ARM, we\nwouldn't even try to install Perforce support at all. We needed to base\nthings off of `$TARGETARCH` instead of `$BUILDARCH`.\n\nThat didn't even matter though, as we never declared we needed that\nvariable. So we skipped the Perforce support in all cases.\n\nAnd finally, even if that did work, we had the wrong command for\ninstalling the p4 support. And we had some bash-isms that didn't work in\nthe shell used to execute these commands.\n\nWe now declare and use `$TARGETARCH` for the comparisons, and properly\ninstall the `p4` binary and `p4python` support whenever we're building\nfor X86.\n\nNote that we can't build for ARM, as `p4python` still hasn't been\nreleased for ARM.\n\nTesting Done:\nBuilt for both ARM and X86, and checked the resulting P4 support in\nboth. Verified that we had it installed properly in X86, and didn't\nhave any of it in ARM.\n\nReviewed at https://reviews.reviewboard.org/r/13897/","shortMessageHtmlLink":"Fix installing Perforce in Docker."}},{"before":"61bbac75b51a19abc238c76a56bf9599a3fa08de","after":"cafe4e13f133f0f135240186ec38b56f3b66e74e","ref":"refs/heads/release-7.x","pushedAt":"2024-05-28T19:31:34.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add dark mode and modern tabs to the text and Markdown review UI.\n\nThe text review UI has been updated to support dark mode styling. The\ntext content already supported dark mode, but the custom tabs and the\noverridden styles for the filename header did not.\n\nWe now use `rb-c-tabs` for the tabs, helping that fit in with much of\nthe UI. We also use the default diff viewer header styling that we\ninherit for the filename information.\n\nTabs had to be updated to ensure we correctly override the `color` and\n`text-decoration` for the label, in case `<a>` is used (which is the\ncase here).\n\nWith this, we now have full dark mode support for text and Markdown\nreview.\n\nTesting Done:\nTested in light and dark modes with single revisions, diffs, plain\ntext, and Markdown files.\n\nReviewed at https://reviews.reviewboard.org/r/13890/","shortMessageHtmlLink":"Add dark mode and modern tabs to the text and Markdown review UI."}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEX4X5iwA","startCursor":null,"endCursor":null}},"title":"Activity · reviewboard/reviewboard"}