Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] the comment of concat_samples() methods may have mistakes? #45399

Open
colourfulspring opened this issue May 17, 2024 · 0 comments
Open
Labels
docs An issue or change related to documentation triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@colourfulspring
Copy link

Description

Hello,

I found you have provided a testcode to show how to use the concat_samples function. However, in the testcode, you defined 2 variables c1 and c2 at Line 1564-1569, but after that, you run print(concat_samples([b1, b2])) at Line 1570. Finally, you said the testoutput is an instance of MultiAgentBatch at Line 1575-1576.

In my opinion, maybe here is a simple typing mistake. print(concat_samples([b1, b2])) at Line 1570 should be print(concat_samples([c1, c2])). Hope you can reply.

Link

https://github.com/ray-project/ray/blob/master/rllib/policy/sample_batch.py#L1570

@colourfulspring colourfulspring added docs An issue or change related to documentation triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 17, 2024
@colourfulspring colourfulspring changed the title [<concat_samples(): rllib.policy.sample_batch>] [docs] the comment of concat_samples() methods may have mistakes? May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

No branches or pull requests

1 participant