Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new crypto/tls 0-RTT API #4272

Open
marten-seemann opened this issue Jan 26, 2024 · 5 comments
Open

use new crypto/tls 0-RTT API #4272

marten-seemann opened this issue Jan 26, 2024 · 5 comments
Labels

Comments

@marten-seemann
Copy link
Member

marten-seemann commented Jan 26, 2024

Proposal: golang/go#63691

An initial implementation is available in the go122-crypto-tls branch.

Update: This will be available in Go 1.23.

@marten-seemann
Copy link
Member Author

https://go-review.googlesource.com/c/go/+/536935 was merged 🎉

@marten-seemann
Copy link
Member Author

Currently blocked on golang/go#67401, since they locked down go:linkname too much.

@yawaramin
Copy link

For my understanding, is this the issue described in https://utcc.utoronto.ca/~cks/space/blog/programming/Go123LinknameComingProblem ?

Ie

link: github.com/quic-go/quic-go/internal/qtls: invalid reference to crypto/tls.defaultCipherSuitesTLS13

@marten-seemann
Copy link
Member Author

Yes this is correct.

@marten-seemann
Copy link
Member Author

The Go team merged the PR, so this new API will be available in Go 1.23.

However, we might not make use of it before Go 1.24, as the benefit of the new API is pretty minimal, especially since the Go team hasn't implement the other changes that would have been needed to avoid copying the tls.Config (see my post here: golang/go#63691 (comment)).

If we wait until Go 1.24, we don't have to deal with supporting both versions of the API, since our policy is to always support the two most recent Go versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants