Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No announcement banner anymore #1817

Closed
dbitouze opened this issue May 16, 2024 · 2 comments · Fixed by #1808
Closed

No announcement banner anymore #1817

dbitouze opened this issue May 16, 2024 · 2 comments · Fixed by #1808

Comments

@dbitouze
Copy link
Contributor

dbitouze commented May 16, 2024 •
edited

With PST 15.3rc1, no announcement banner anymore, despite:

html_theme_options = {
    ...
    "announcement": "Nouvelle version de la FAQ LaTeX GUTenberg !",
    ...
}

in conf.py.
Capture d'écran 2024-05-16 22:25:35

It used to work, e.g. with PST 0.14.4.
@melissawm
Copy link
Contributor

OOps - probably my fault in #1703 ? I'll take a look

@melissawm
Copy link
Contributor

Actually it's some new javascript that was only added to the remote option of the announcement banner, I'll submit a PR soon for a fix. Thanks @dbitouze !

@dbitouze dbitouze changed the title No more announcement banner No announcement banner anymore May 17, 2024
melissawm added a commit to melissawm/pydata-sphinx-theme that referenced this issue May 17, 2024
@melissawm
Fix display of local announcement banner
96bd58c 
Closes pydatagh-1817
@melissawm melissawm mentioned this issue May 17, 2024
Closed
@gabalafou gabalafou linked a pull request May 20, 2024 that will close this issue
Animate remotely loaded banners together #1808
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dbitouze @melissawm