Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.5 support #94

Open
dzhu opened this issue Feb 4, 2020 · 4 comments
Open

Python 3.5 support #94

dzhu opened this issue Feb 4, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@dzhu
Copy link

dzhu commented Feb 4, 2020

I would like to use sgqlc for a project that is currently committed to supporting Python 3.5 (among other versions). Would it be possible to add Python 3.5 support to sgqlc? I'm hoping it might not be a huge amount of work: I haven't done a thorough check, but I was able to install sgqlc, run sgqlc-codegen, and use the generated code to make some queries after very minimal changes to the code -- I just had to edit setup.py to change the version requirement and remove the one use of an f-string. It does look like getting the tests to run will be take a bit more tweaking, though.

@barbieri
Copy link
Member

barbieri commented Feb 4, 2020

I never bothered to check, if the f-strings are the only issue, I'm fine to apply patches converting to more traditional string formatting.

@barbieri barbieri self-assigned this Feb 4, 2020
@barbieri barbieri added the enhancement New feature or request label Feb 4, 2020
@dzhu
Copy link
Author

dzhu commented Feb 5, 2020

Thanks! But sorry, I'm not quite clear -- are you intending to work on this yourself or are you saying that PRs would be welcome?

@barbieri
Copy link
Member

barbieri commented Feb 5, 2020

PRs would be welcome :-)

quite overloaded with work these days, not able to work on it myself.

@dzhu
Copy link
Author

dzhu commented Feb 5, 2020

Sounds good. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants