Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestsEndpoint does not intercept ReadTimeout errors #168

Open
grazzolini opened this issue Sep 23, 2021 · 1 comment
Open

RequestsEndpoint does not intercept ReadTimeout errors #168

grazzolini opened this issue Sep 23, 2021 · 1 comment
Assignees

Comments

@grazzolini
Copy link

When using the RequestsEndpoint for fetching data, if you do not set the timeout, it uses requests defaults, which means no timeout.

However, if setting a timeout, the endpoint is not intercepting ReadTimeout errors. This is fine, and I can intercept this when making the call, but it would be nice if sgqlc also handled this. If this is something that the project wants, I can make a PR for this.

Judging by the HTTPEndpoint code, it's also not intercepting timeout errors, but I have not tested this to be sure.

@barbieri
Copy link
Member

Indeed, we're not intercepting those. It would be nice to, then translate to the common error.

If you can provide a PR, excellent. If you can check that for other endpoints, even better :-)

@barbieri barbieri self-assigned this Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants