Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree table unit test #15618

Conversation

dobanisola-scottlogic
Copy link
Contributor

Fixes #15589

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 0:57am

@dobanisola-scottlogic dobanisola-scottlogic marked this pull request as ready for review May 20, 2024 08:47
@dobanisola-scottlogic
Copy link
Contributor Author

@robGardiner01 @nbrown-ScottLogic @RogueTea Okay to review this?

@nbrown-ScottLogic
Copy link
Contributor

nbrown-ScottLogic commented May 20, 2024

@robGardiner01 @nbrown-ScottLogic @RogueTea Okay to review this?

Looks good thanks!

Is the which depreciated? Why is it better to use code than which?

Copy link
Contributor

@robGardiner01 robGardiner01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple questions about the describes

src/app/components/treetable/treetable.spec.ts Outdated Show resolved Hide resolved
@dobanisola-scottlogic
Copy link
Contributor Author

@robGardiner01 @nbrown-ScottLogic @RogueTea Okay to review this?

Looks good thanks!

Is the which depreciated? Why is it better to use code than which?

@nbrown-ScottLogic Yes, which has been deprecated. https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/which
It's better to use key or code.

@RogueTea
Copy link
Contributor

Looks good to me.

@cetincakiroglu cetincakiroglu merged commit acf9f8e into primefaces:master May 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeTable Component: fix unit test
5 participants