Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 compatibility: XMLRPC #395

Open
Yuubari opened this issue Nov 2, 2020 · 5 comments
Open

PHP 8.0 compatibility: XMLRPC #395

Yuubari opened this issue Nov 2, 2020 · 5 comments
Labels

Comments

@Yuubari
Copy link

Yuubari commented Nov 2, 2020

XMLRPC is no longer bundled with PHP starting with 8.0: https://wiki.php.net/rfc/unbundle_xmlprc — are there any plans to maybe migrate to something like https://github.com/lstrojny/fxmlrpc or drop XMLRPC altogether?

@DavidGoodwin
Copy link
Member

Ideally we'd drop XMLRPC and move to something REST-ish ... as at least that'd be more understood/easier to debug/less magical/remove a dependency on ZF1....

@DavidGoodwin
Copy link
Member

(xmlrpc is only an optional dependency really ...)

Ma27 added a commit to mayflower/nixpkgs that referenced this issue Aug 24, 2021
Even though some PHP8 compat fixes seem to be in the release that's
packaged here, it seems as if there are still some minor issues[1].

[1] postfixadmin/postfixadmin#395
@bnchdan
Copy link
Contributor

bnchdan commented Jan 12, 2022

If you don't have Zend installed ( for the client-side), you can send a simple XML request with specific arguments.
For login, you need to send an xml as follow :

image

Take a look at this: https://github.com/bnchdan/xmlrpc_client

@DavidGoodwin
Copy link
Member

@bnchdan thanks for the link - you'd need to call something boring like htmlspecialchars(..) on anything you embed into the XML like how you are - e.g. if my password was "123<456" https://github.com/bnchdan/xmlrpc_client/blob/4875ae1124289d9dd0b2928be1c04bfc1c0aa3d2/changepassword.php#L29 it would break the generated XML

a better approach would be to use SimpleXML or is it libxml ( ? ) to create the XML document, as that should take care of escaping stuff.

I think you should look at e.g. https://github.com/milo/xml-rpc

@DavidGoodwin
Copy link
Member

fyi, i see e.g. the sury.org PHP variant has an xmlrpc extension ... so it kind of looks like xmlrpc is still possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants