-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.0 compatibility: XMLRPC #395
Comments
Ideally we'd drop XMLRPC and move to something REST-ish ... as at least that'd be more understood/easier to debug/less magical/remove a dependency on ZF1.... |
(xmlrpc is only an optional dependency really ...) |
Even though some PHP8 compat fixes seem to be in the release that's packaged here, it seems as if there are still some minor issues[1]. [1] postfixadmin/postfixadmin#395
If you don't have Zend installed ( for the client-side), you can send a simple XML request with specific arguments. Take a look at this: https://github.com/bnchdan/xmlrpc_client |
@bnchdan thanks for the link - you'd need to call something boring like htmlspecialchars(..) on anything you embed into the XML like how you are - e.g. if my password was "123<456" https://github.com/bnchdan/xmlrpc_client/blob/4875ae1124289d9dd0b2928be1c04bfc1c0aa3d2/changepassword.php#L29 it would break the generated XML a better approach would be to use SimpleXML or is it libxml ( ? ) to create the XML document, as that should take care of escaping stuff. I think you should look at e.g. https://github.com/milo/xml-rpc |
fyi, i see e.g. the sury.org PHP variant has an xmlrpc extension ... so it kind of looks like xmlrpc is still possible? |
XMLRPC is no longer bundled with PHP starting with 8.0: https://wiki.php.net/rfc/unbundle_xmlprc — are there any plans to maybe migrate to something like https://github.com/lstrojny/fxmlrpc or drop XMLRPC altogether?
The text was updated successfully, but these errors were encountered: